From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DDDC433F5 for ; Thu, 19 May 2022 14:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239079AbiESOI3 (ORCPT ); Thu, 19 May 2022 10:08:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231636AbiESOI2 (ORCPT ); Thu, 19 May 2022 10:08:28 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E58260DAA; Thu, 19 May 2022 07:08:25 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BC5E740008; Thu, 19 May 2022 14:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1652969304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+rE6gwbsgS2oLBE5ddkY8KWT/D++rFRsrz02UqzfbA0=; b=aPkZForcz0tz/Aw46CNMJMpI7XvW/l1HK3cHVZzSYwx8BgmXt/WrSRTNQCaITFWsy5TApt R7JHJ6BgTMkCohBdyZ90J93730DkNkWduvTeaXItZkRi1fUBvSaQJVGyIDwaYJv5gR+aOm tp3z++yjlin3TIFyM5IHKubuYsbheOYr/gaKn48ZPkwDuVm3NrOpMult+YeXWIKew2Bkl+ /jfiCSnQmOf8HITFfEPxgNdjcMnI79x/0kK5j68cUixpXmg8yjyiKFcpOi4PAnHT54TqAa gZwCEygPK2HI7H/LtA7Ec8QYQ0Yxgngn60vjbhv2ViFQF6hWPFsl8wYQKQ8Gtw== Date: Thu, 19 May 2022 16:08:21 +0200 From: Miquel Raynal To: Dan Carpenter Cc: Michel Pollet , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rtc: rzn1: Fix error code in probe Message-ID: <20220519160821.14230810@xps-13> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hi Dan, dan.carpenter@oracle.com wrote on Thu, 19 May 2022 16:56:19 +0300: > There is a copy and paste error so this code returns the wrong variable. >=20 > Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver") The Fixes here will point to an unknown id once pulled by Linus. Otherwise Reviewed-by: Miquel Raynal > Signed-off-by: Dan Carpenter > --- > drivers/rtc/rtc-rzn1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c > index 0b4bf6e43464..ff49cedd98b8 100644 > --- a/drivers/rtc/rtc-rzn1.c > +++ b/drivers/rtc/rtc-rzn1.c > @@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) > =20 > rtc->rtcdev =3D devm_rtc_allocate_device(&pdev->dev); > if (IS_ERR(rtc->rtcdev)) > - return PTR_ERR(rtc); > + return PTR_ERR(rtc->rtcdev); > =20 > rtc->rtcdev->range_min =3D RTC_TIMESTAMP_BEGIN_2000; > rtc->rtcdev->range_max =3D RTC_TIMESTAMP_END_2099; Thanks, Miqu=C3=A8l