From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B17BEC433F5 for ; Mon, 23 May 2022 07:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229768AbiEWH6j (ORCPT ); Mon, 23 May 2022 03:58:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbiEWH6h (ORCPT ); Mon, 23 May 2022 03:58:37 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 061A2EAF; Mon, 23 May 2022 00:58:33 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EB76B200007; Mon, 23 May 2022 07:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1653292712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YnX7d82uLFyXKL9RU+Q7pPoOWV1qdJm9PA8IlytzpR4=; b=hh+FeoLrN8cwOptCVVTPnujUtQHs3s/JsJtan241Z5qxAM3MUOf1PxyeN7OZT6YXNKzRnh hR5Knfa/g3U39o9d13vOb6zxaeymm/KIDDOzkcU/Yw9g6NYUOtq8o4WpOqtJQeIA+FbqRJ fuhSjJ3wRPg7+36umHY7t9J8NOe9bZr0zPpQOv7+8IxS90ZOO1oXhxYCc1P1oeA0MJepSP 0Fe7v/1UBj7SmI2YmgJkGBLlKziDKLodYQiL6yTPXVtkwVKwwh/a7D+JGB/KbgkFf/DuZI liEJqWiRRM2xeDbFnDHWEp1q3zF7G4QCkDZpqdV+I7CrtKvPZqRs3fQ/bimOaQ== Date: Mon, 23 May 2022 09:58:31 +0200 From: Miquel Raynal To: Ziyang Xuan Cc: , , , Subject: Re: [PATCH] rtc: rzn1: fix inconsistent IS_ERR and PTR_ERR Message-ID: <20220523095831.241380cd@xps-13> In-Reply-To: <20220523015725.198244-1-william.xuanziyang@huawei.com> References: <20220523015725.198244-1-william.xuanziyang@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hi Ziyang, william.xuanziyang@huawei.com wrote on Mon, 23 May 2022 09:57:25 +0800: > It is inconsistent IS_ERR and PTR_ERR for rtc->rtcdev in rzn1_rtc_probe(). >=20 > Generated by coccinelle script: > scripts/coccinelle/tests/odd_ptr_err.cocci >=20 > Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver") > Signed-off-by: Ziyang Xuan > --- > drivers/rtc/rtc-rzn1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c > index f92d1398b0f1..4cf54af8a8c3 100644 > --- a/drivers/rtc/rtc-rzn1.c > +++ b/drivers/rtc/rtc-rzn1.c > @@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pde= v) > =20 > rtc->rtcdev =3D devm_rtc_allocate_device(&pdev->dev); > if (IS_ERR(rtc->rtcdev)) > - return PTR_ERR(rtc); > + return PTR_ERR(rtc->rtcdev); Thanks for the patch, but Dan Carpenter already provided the exact same fix. Cheers, Miqu=C3=A8l