From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
kernel@pengutronix.de
Subject: Re: [PATCH v2 0/2] rtc: rv8803 patches
Date: Tue, 18 Oct 2022 09:53:45 +0200 [thread overview]
Message-ID: <20221018075345.gknzmdpxqqoxpcfo@pengutronix.de> (raw)
In-Reply-To: <20221006115346.d4q4y6rrfumqn7tz@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2242 bytes --]
Hello Alexandre,
On 06.10.2022 13:53:46, Marc Kleine-Budde wrote:
> Hi Alexandre,
>
> On 26.09.2022 11:23:13, Ahmad Fatoum wrote:
> > Hello Alexandre,
> > Hello Sascha,
> >
> > On 21.09.22 15:35, Sascha Hauer wrote:
> > > On Wed, Sep 21, 2022 at 04:22:09PM +0200, Alexandre Belloni wrote:
> > >> Hi,
> > >>
> > >> On 21/09/2022 15:17:53+0200, Sascha Hauer wrote:
> > >>> Hi Alexandre,
> > >>>
> > >>> Any input to this series?
> > >>
> > >> I'm not convinced this is necessary. Having an invalid alarm doesn't
> > >> mean that the time is invalid and that check will only ever happen at
> > >> boot time whereas V2F is a reliable indication that the time is invalid.
> > >>
> > >> Have you really had an RTC with an invalid time that is not caught by
> > >> rtc_valid_tm and with V2F not set?
> > >
> > > I don't know. I must talk to Ahmad in this regard, he'll be back next
> > > week. It could be that we only created this patch to be sure the RTC
> > > state is sane.
> >
> > The kernel message
> >
> > rtc rtc0: invalid alarm value: 2020-3-27 7:82:0
> >
> > listed in the commit message is something I actually ran into. There
> > was no v2f set then. The customer has also variously observed bit flips
> > independently of v2f: During EMC testing, electrostatic discharge at developer
> > desks and even in the field: Suspected causes were lightning strikes in the
> > vicinity and the switching of larger inductive loads.
> > They're very paranoid of logging invalid timestamps, so we'll keep the patch
> > anyhow at our side, but I think it is generally useful as well: If we can't
> > set an invalid alarm time by normal means, but read back an invalid time,
> > something may have corrupted other memory, so treating it as a v2f is sensible.
>
> Should we re-send the patch with an updated patch description, or do you
> take it as is?
As v6.1-rc1 just came out, what about this patch?
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-10-18 7:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 8:53 [PATCH v2 0/2] rtc: rv8803 patches Sascha Hauer
2022-08-17 8:53 ` [PATCH v2 1/2] include/linux/bcd.h: provide bcd_is_valid() helper Sascha Hauer
2022-08-17 8:53 ` [PATCH v2 2/2] rtc: rv8803: invalidate date/time if alarm time is invalid Sascha Hauer
2022-09-21 13:17 ` [PATCH v2 0/2] rtc: rv8803 patches Sascha Hauer
2022-09-21 14:22 ` Alexandre Belloni
2022-09-21 14:35 ` Sascha Hauer
2022-09-26 10:23 ` Ahmad Fatoum
2022-10-06 11:53 ` Marc Kleine-Budde
2022-10-18 7:53 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018075345.gknzmdpxqqoxpcfo@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=linux-rtc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).