From: Rob Herring <robh@kernel.org>
To: Wadim Egorov <w.egorov@phytec.de>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
upstream@lists.phytec.de, riku.voipio@iki.fi,
alexandre.belloni@bootlin.com, a.zummo@towertech.it,
krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, pavel@ucw.cz
Subject: Re: [PATCH v2 2/2] dt-bindings: rtc: Move rv3028 from trivial-rtc.yaml into own schema file
Date: Fri, 13 Jan 2023 13:25:04 -0600 [thread overview]
Message-ID: <20230113192504.GA2800695-robh@kernel.org> (raw)
In-Reply-To: <20230111163404.3526248-2-w.egorov@phytec.de>
On Wed, Jan 11, 2023 at 05:34:04PM +0100, Wadim Egorov wrote:
> Move RV3028 RTC bindings from trivial-rtc.yaml into microcrystal,rv3032.yaml.
That's obvious from the diff. What's not obvious is 'why' and the commit
message should answer that. I assume something about it makes it not
trivial.
>
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> v2:
> - Update subject
> - Remove not needed quotes
> - Remove start-year
> - Use unevaluatedProperties instead of additionalProperties
> ---
> .../bindings/rtc/microcrystal,rv3028.yaml | 54 +++++++++++++++++++
> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 -
> 2 files changed, 54 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
Otherwise,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-01-13 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 16:34 [PATCH v2 1/2] dt-bindings: leds: Convert PCA9532 to dtschema Wadim Egorov
2023-01-11 16:34 ` [PATCH v2 2/2] dt-bindings: rtc: Move rv3028 from trivial-rtc.yaml into own schema file Wadim Egorov
2023-01-13 19:25 ` Rob Herring [this message]
2023-01-23 23:40 ` (subset) " Alexandre Belloni
2023-01-11 18:47 ` [PATCH v2 1/2] dt-bindings: leds: Convert PCA9532 to dtschema Rob Herring
2023-01-11 18:51 ` Rob Herring
2023-01-13 16:18 ` Wadim Egorov
2023-01-13 19:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113192504.GA2800695-robh@kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=riku.voipio@iki.fi \
--cc=upstream@lists.phytec.de \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).