From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: pcf85363: Allow to wake up system without IRQ
Date: Fri, 18 Aug 2023 00:25:43 +0200 [thread overview]
Message-ID: <202308172225433f4bb84b@mail.local> (raw)
In-Reply-To: <5113ab6e-881b-fa6b-00c4-118b32be4a4c@topic.nl>
On 17/08/2023 11:02:43+0200, Mike Looijmans wrote:
> > My comment was also for device_init_wakeup(&client->dev, true);. I think
> > the easiest would be to move this block later on and set client->irq to
> > 0 when devm_request_threaded_irq fails.
> >
>
> Ah, clear. That also properly handles things when IRQ fails but
> wakeup-source was present. In table form:
>
> IRQ wakeup-source Call "device_init_wakeup" etc.
> N/A No No
> N/A Yes Yes
> OK No Yes
> OK Yes Yes
This case is forbidden, you must not have an interrupt property and
wakeup-source at the same time.
> FAIL No No
> FAIL Yes Yes
This is then also forbidden
>
> We still have to program the registers before registering the IRQ I think.
Yes, certainly.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2023-08-17 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.eeedf5db-4013-4c3b-be1c-1121df58f897@emailsignatures365.codetwo.com>
2023-05-02 5:54 ` [PATCH] rtc: pcf85363: Allow to wake up system without IRQ Mike Looijmans
2023-08-16 21:40 ` Alexandre Belloni
2023-08-17 5:42 ` Mike Looijmans
2023-08-17 8:17 ` Alexandre Belloni
2023-08-17 9:02 ` Mike Looijmans
2023-08-17 22:25 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308172225433f4bb84b@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).