From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] rtc: rx8581: Simplify probe()
Date: Mon, 28 Aug 2023 14:27:13 +0200 [thread overview]
Message-ID: <2023082812271359f2dadd@mail.local> (raw)
In-Reply-To: <20230828090828.26897-1-biju.das.jz@bp.renesas.com>
On 28/08/2023 10:08:28+0100, Biju Das wrote:
> Make similar OF and ID table and simplify probe() by replacing
> of_device_get_match_data()->i2c_get_match_data().
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> Note:
> * This patch is only compile tested.
As you have access to a rx8571, please actually test.
> ---
> drivers/rtc/rtc-rx8581.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c
> index 48efd61a114d..68dd8b9b52f9 100644
> --- a/drivers/rtc/rtc-rx8581.c
> +++ b/drivers/rtc/rtc-rx8581.c
> @@ -250,8 +250,7 @@ static const struct rx85x1_config rx8571_config = {
> static int rx8581_probe(struct i2c_client *client)
> {
> struct rx8581 *rx8581;
> - const struct rx85x1_config *config = &rx8581_config;
> - const void *data = of_device_get_match_data(&client->dev);
> + const struct rx85x1_config *config = i2c_get_match_data(client);
> static struct nvmem_config nvmem_cfg[] = {
> {
> .name = "rx85x1-",
> @@ -273,9 +272,6 @@ static int rx8581_probe(struct i2c_client *client)
>
> dev_dbg(&client->dev, "%s\n", __func__);
>
> - if (data)
> - config = data;
> -
> rx8581 = devm_kzalloc(&client->dev, sizeof(struct rx8581), GFP_KERNEL);
> if (!rx8581)
> return -ENOMEM;
> @@ -307,7 +303,7 @@ static int rx8581_probe(struct i2c_client *client)
> }
>
> static const struct i2c_device_id rx8581_id[] = {
> - { "rx8581", 0 },
> + { "rx8581", (kernel_ulong_t)&rx8581_config },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, rx8581_id);
> --
> 2.25.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-08-28 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 9:08 [PATCH] rtc: rx8581: Simplify probe() Biju Das
2023-08-28 12:27 ` Alexandre Belloni [this message]
2023-08-28 12:35 ` Biju Das
2023-08-29 12:44 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082812271359f2dadd@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox