From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="LvPjr6Vf" Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA9EF10D8; Fri, 1 Dec 2023 07:20:13 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AA4141BF206; Fri, 1 Dec 2023 15:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701444012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wM5OHPLsXa1vxZ4TVCD3/a/nwUaLHqi0SxNldNQwSdw=; b=LvPjr6VfI/Cikhv4tfSqklE+QrQR3EsdBlW9hPGCOlQ+Tu2udZ7iYvBAatoFuDIxZOvwuN WHoW51Jn/v6SOljOTWCtv01eWySpFQvC0UHHRqBsaAiiRQztp3VT2kBZUS/j2AaGu+mLgq UhFfnZVpTSIPdttzX/QmoFb0EUuwViYmr/MZmJ4rMhwxkCj6WYcvE/pbmeJt8+YNVXViJ/ jDIFyHkhYvHerevvuF1lSKLd/SIAEszkiJ7atNE0g8r8ypAYS0uQInEKjMDBXO53cKcsPY 1jgrY9Ytss1I8kvSrOIPscYroKqXX1TK1imbCQEF4r2nzn+D5OL8tWSfvHoQmg== Date: Fri, 1 Dec 2023 16:20:10 +0100 From: Alexandre Belloni To: Biju Das Cc: Geert Uytterhoeven , Alessandro Zummo , Support Opensource , "linux-rtc@vger.kernel.org" , Prabhakar Mahadev Lad , "biju.das.au" , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH 3/6] rtc: da9063: Use dev_err_probe() Message-ID: <202312011520103c5f28dc@mail.local> References: <20231201110840.37408-1-biju.das.jz@bp.renesas.com> <20231201110840.37408-4-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-GND-Sasl: alexandre.belloni@bootlin.com On 01/12/2023 13:30:05+0000, Biju Das wrote: > Hi Geert, > > Thanks for the feedback. > > > -----Original Message----- > > From: Geert Uytterhoeven > > Subject: Re: [PATCH 3/6] rtc: da9063: Use dev_err_probe() > > > > Hi Biju, > > > > On Fri, Dec 1, 2023 at 12:08 PM Biju Das > > wrote: > > > Replace dev_err()->dev_err_probe() to simpilfy probe(). > > > > > > Signed-off-by: Biju Das > > > > Thanks for your patch! > > > > > --- a/drivers/rtc/rtc-da9063.c > > > +++ b/drivers/rtc/rtc-da9063.c > > > @@ -488,8 +480,9 @@ static int da9063_rtc_probe(struct platform_device > > *pdev) > > > IRQF_TRIGGER_LOW | > > IRQF_ONESHOT, > > > "ALARM", rtc); > > > if (ret) > > > - dev_err(&pdev->dev, "Failed to request ALARM > > IRQ %d: %d\n", > > > - irq_alarm, ret); > > > + return dev_err_probe(&pdev->dev, ret, > > > + "Failed to request ALARM > > IRQ %d\n", > > > + irq_alarm); > > > > This changes behavior: before, this was not considered fatal. > > Agreed. Maybe a separate patch? > > if there is no irqhandler on platform with IRQ populated nothing will work, > RTC won't work as "rtc_update_irq " updated in irq handler. > I think it is a fatal condition. This is not true, an RTC can wake up a system without an IRQ. > > Cheers, > Biju > > > > > > > > > ret = dev_pm_set_wake_irq(&pdev->dev, irq_alarm); > > > if (ret) > > > > The rest LGTM, so with the above fixed/clarified: > > Reviewed-by: Geert Uytterhoeven > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > > m68k.org > > > > In personal conversations with technical people, I call myself a hacker. > > But when I'm talking to journalists I just say "programmer" or something > > like that. > > -- Linus Torvalds -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com