From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Richard GENOUD <richard.genoud@bootlin.com>
Cc: Thomas Richard <thomas.richard@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Udit Kumar <u-kumar1@ti.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Esteban Blanc <eblanc@baylibre.com>,
linux-rtc@vger.kernel.org, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] rtc: tps6594: Add power management support
Date: Tue, 18 Jun 2024 17:17:49 +0200 [thread overview]
Message-ID: <20240618151749d6ed0733@mail.local> (raw)
In-Reply-To: <c4ce3a14-fb28-4c34-abc1-9b0ae1c1a82f@bootlin.com>
On 18/06/2024 11:48:33+0200, Richard GENOUD wrote:
> Le 14/06/2024 à 15:21, Thomas Richard a écrit :
> > > diff --git a/include/linux/mfd/tps6594.h b/include/linux/mfd/tps6594.h
> > > index 3f7c5e23cd4c..85933f1519c4 100644
> > > --- a/include/linux/mfd/tps6594.h
> > > +++ b/include/linux/mfd/tps6594.h
> > > @@ -1011,6 +1011,7 @@ struct tps6594 {
> > > bool use_crc;
> > > struct regmap *regmap;
> > > int irq;
> > > + int irq_rtc;
> >
> > irq_rtc should be stored in driver data.
> I understand your point.
> It may indeed be cleaner to separate the rtc-specific data into a private
> struct.
>
> I'll send a v3 with this modification, and I'll let Alexandre decide which
> he prefers.
My plan is to take v2 as-is
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-06-18 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 15:28 [PATCH v2 0/1] rtc: tps6594: Add power management support Richard Genoud
2024-05-15 15:28 ` [PATCH v2 1/1] " Richard Genoud
2024-05-15 16:11 ` Esteban Blanc
2024-05-31 13:36 ` Lee Jones
2024-06-14 13:21 ` Thomas Richard
2024-06-18 9:48 ` Richard GENOUD
2024-06-18 15:17 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618151749d6ed0733@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=eblanc@baylibre.com \
--cc=gregory.clement@bootlin.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=richard.genoud@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).