* [PATCH] rtc: s35390a: Drop vendorless compatible string from match table
@ 2024-08-26 19:13 Rob Herring (Arm)
2024-09-11 22:18 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-08-26 19:13 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc, linux-kernel
There's no need to list "s35390a" in the DT match table. The I2C core
will strip any vendor prefix and match against the i2c_device_id table
which has an "s35390a" entry.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/rtc/rtc-s35390a.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c
index 2d6b655a4b25..e3dc18882f41 100644
--- a/drivers/rtc/rtc-s35390a.c
+++ b/drivers/rtc/rtc-s35390a.c
@@ -56,7 +56,6 @@ static const struct i2c_device_id s35390a_id[] = {
MODULE_DEVICE_TABLE(i2c, s35390a_id);
static const __maybe_unused struct of_device_id s35390a_of_match[] = {
- { .compatible = "s35390a" },
{ .compatible = "sii,s35390a" },
{ }
};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: s35390a: Drop vendorless compatible string from match table
2024-08-26 19:13 [PATCH] rtc: s35390a: Drop vendorless compatible string from match table Rob Herring (Arm)
@ 2024-09-11 22:18 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2024-09-11 22:18 UTC (permalink / raw)
To: Rob Herring (Arm); +Cc: linux-rtc, linux-kernel
On Mon, 26 Aug 2024 14:13:20 -0500, Rob Herring (Arm) wrote:
> There's no need to list "s35390a" in the DT match table. The I2C core
> will strip any vendor prefix and match against the i2c_device_id table
> which has an "s35390a" entry.
>
>
Applied, thanks!
[1/1] rtc: s35390a: Drop vendorless compatible string from match table
https://git.kernel.org/abelloni/c/da1531ecf186
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-11 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 19:13 [PATCH] rtc: s35390a: Drop vendorless compatible string from match table Rob Herring (Arm)
2024-09-11 22:18 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).