Re: [PATCH v6 2/2] dt-bindings: rtc: Add support for SD2405AL.

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]

On Thu, Aug 29, 2024 at 01:31:45PM +0200, Tóth János via B4 Relay wrote:
> From: Tóth János <gomba007@gmail.com>
> 
> Add the necessary documentation for SD2405AL.
> 
> Signed-off-by: Tóth János <gomba007@gmail.com>
> ---
>  Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++

Both of these should really be two different patches, despite how
trivial they would be. If you resubmit, please do that and provide a
link to the vendor in the vendor-prefixes patch. Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> index fffd759c603f..dae594626b2e 100644
> --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> @@ -38,6 +38,8 @@ properties:
>        - dallas,ds1672
>        # Extremely Accurate I²C RTC with Integrated Crystal and SRAM
>        - dallas,ds3232
> +      # SD2405AL Real-Time Clock
> +      - dfrobot,sd2405al
>        # EM Microelectronic EM3027 RTC
>        - emmicro,em3027
>        # I2C-BUS INTERFACE REAL TIME CLOCK MODULE
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index a70ce43b3dc0..bd8b279a5152 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -368,6 +368,8 @@ patternProperties:
>      description: Devantech, Ltd.
>    "^dfi,.*":
>      description: DFI Inc.
> +  "^dfrobot,.*":
> +    description: DFRobot Corporation
>    "^dh,.*":
>      description: DH electronics GmbH
>    "^difrnce,.*":
> 
> -- 
> 2.34.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]