From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Junhao Xie" <bigfoot@classfun.cn>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Chukun Pan" <amadeus@jmu.edu.cn>,
"Conor Dooley" <conor+dt@kernel.org>,
"Günter Röck" <linux@roeck-us.net>,
"Heiko Stübner" <heiko@sntech.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>
Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU
Date: Thu, 12 Sep 2024 08:55:23 +0100 [thread overview]
Message-ID: <20240912075523.GB24460@google.com> (raw)
In-Reply-To: <917ac8d8-a483-422c-a408-cdd44793e910@kernel.org>
On Sun, 08 Sep 2024, Krzysztof Kozlowski wrote:
> On 07/09/2024 16:33, Junhao Xie wrote:
> > On 2024/9/7 16:44, Markus Elfring wrote:
> >> …
> >>> +++ b/include/linux/mfd/photonicat-pmu.h
> >>> @@ -0,0 +1,86 @@
> >> …
> >>> +#ifndef _PHOTONICAT_PMU_H
> >>> +#define _PHOTONICAT_PMU_H
> >> …
> >>
> >> I suggest to omit leading underscores from such identifiers.
> >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
> >>
> >> Regards,
> >> Markus
> >
> > Thanks for your suggestion, does this look better?
> > #ifndef MFD_PHOTONICAT_PMU_H
> > #define MFD_PHOTONICAT_PMU_H
Yes, this is better.
> <form letter>
> Feel free to ignore all comments from Markus, regardless whether the
> suggestion is reasonable or not. This person is banned from LKML and
> several maintainers ignore Markus' feedback, because it is just a waste
> of time.
> </form letter>
If you really _must_ do this, at least keep it factual.
To the best of my knowledge Markus is not banned from LKML.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-09-12 7:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:36 [PATCH 0/9] Introduce Photonicat power management MCU driver Junhao Xie
2024-09-06 9:36 ` [PATCH 1/9] mfd: Add driver for Photonicat power management MCU Junhao Xie
2024-09-06 9:43 ` Krzysztof Kozlowski
2024-09-06 10:40 ` Junhao Xie
2024-09-07 8:10 ` Markus Elfring
2024-09-07 14:46 ` Junhao Xie
2024-09-07 8:44 ` Markus Elfring
2024-09-07 14:33 ` Junhao Xie
2024-09-08 8:14 ` Krzysztof Kozlowski
2024-09-12 7:55 ` Lee Jones [this message]
2024-09-06 9:36 ` [PATCH 2/9] power: reset: add Photonicat PMU poweroff driver Junhao Xie
2024-09-06 9:44 ` Krzysztof Kozlowski
2024-09-06 10:05 ` Junhao Xie
2024-09-06 9:36 ` [PATCH 3/9] watchdog: Add Photonicat PMU watchdog driver Junhao Xie
2024-09-06 11:52 ` Guenter Roeck
2024-09-06 13:41 ` Junhao Xie
2024-09-06 9:36 ` [PATCH 4/9] power: supply: photonicat-supply: Add Photonicat PMU battery and charger Junhao Xie
2024-09-06 9:36 ` [PATCH 5/9] rtc: Add Photonicat PMU real-time clock Junhao Xie
2024-09-06 9:36 ` [PATCH 6/9] hwmon: Add support for Photonicat PMU board temperature sensor Junhao Xie
2024-09-06 11:41 ` Guenter Roeck
2024-09-06 13:49 ` Junhao Xie
2024-09-06 14:33 ` Guenter Roeck
2024-09-06 9:36 ` [PATCH 7/9] leds: add Photonicat PMU LED driver Junhao Xie
2024-10-02 15:35 ` Lee Jones
2024-11-08 3:48 ` Junhao Xie
2024-09-06 9:36 ` [PATCH 8/9] dt-bindings: Add documentation for Photonicat PMU Junhao Xie
2024-09-06 9:51 ` Krzysztof Kozlowski
2024-09-07 14:27 ` Junhao Xie
2024-09-08 8:13 ` Krzysztof Kozlowski
2024-09-06 9:36 ` [PATCH 9/9] arm64: dts: rockchip: add Photonicat PMU support for Ariaboard Photonicat Junhao Xie
2024-09-06 9:53 ` Krzysztof Kozlowski
2024-09-06 13:56 ` Junhao Xie
2024-09-06 9:45 ` [PATCH 0/9] Introduce Photonicat power management MCU driver Krzysztof Kozlowski
2024-09-06 10:20 ` Junhao Xie
2024-09-08 9:30 ` Chukun Pan
2024-09-11 6:23 ` Junhao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912075523.GB24460@google.com \
--to=lee@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=amadeus@jmu.edu.cn \
--cc=bigfoot@classfun.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).