From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035FA18E349; Thu, 12 Sep 2024 07:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726127732; cv=none; b=dacyhsAvLjOykFXReeU6h9OecENu81642d0tVC5M5Nm4A18QHAjt6g6990Bnqpar/RGvlHQA2LSkXKIBsqD5mrwTQODaiRLKXbNWX0TBCWugVeVQGL1St4SyhKUwjcI0TIeOMTEHDDE/0dYQcIvyEOaR6DOYITRPuXeupX2TNo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726127732; c=relaxed/simple; bh=4s+VuwhVbNSAVesYDsrgOzVFuC3dn4Fh96NjWQHHSd4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T6c1sWxW5fA2B1SCV5IYRE/M97KXKOLAexRDTrIf17CQUHWmvnfRe6FQIoPmsD0HPKH3tqmqpx7zGyPJf6ClV7B5S3lWkVSZkvQUOkWdpJaSVebTbRRcwaOjjhN/VbKPFlYjDO6HgLFA2XHJYy84rQsYYenCm4IfA7u+vX5R7rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RE4Jpos0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RE4Jpos0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BDB5C4CEC3; Thu, 12 Sep 2024 07:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726127730; bh=4s+VuwhVbNSAVesYDsrgOzVFuC3dn4Fh96NjWQHHSd4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RE4Jpos0PNEzX+j4gvv4HnNOrUggjKzwMILkyBwl0ysVmjqAOlVX/mQhrIQNly6u5 D4cMLo65bYBMzWlE/3MbcvaGJgeSBNYdVepAt76I+DLSY7juHCYtKFtFSF+NxXRLnf nw0U9baOT3m36ADEOMsC52DEtH41CuFRaJgFalbX5iXcl4IyQp85V7KiijKjx0cNGT 6KayroEwMI5tGGbabloSBt1YK8gCKXHgprPzBlO8p/mD27xX6IExuLkytas4cCy+Lx FeyB97LCD7R1E9Adejrws3/2lIKYd4KEQJJgQvTdJ/MZTah6JaIHWY/t17UQPpDuJl ey2Ge3BBptu3g== Date: Thu, 12 Sep 2024 08:55:23 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Junhao Xie , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, LKML , Alexandre Belloni , Chukun Pan , Conor Dooley , =?iso-8859-1?Q?G=FCnter_R=F6ck?= , Heiko =?iso-8859-1?Q?St=FCbner?= , Jean Delvare , Krzysztof Kozlowski , Pavel Machek , Rob Herring , Sebastian Reichel , Wim Van Sebroeck Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU Message-ID: <20240912075523.GB24460@google.com> References: <20240906093630.2428329-2-bigfoot@classfun.cn> <43918eda-c4e8-471a-9de4-ea72bb090803@classfun.cn> <917ac8d8-a483-422c-a408-cdd44793e910@kernel.org> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <917ac8d8-a483-422c-a408-cdd44793e910@kernel.org> On Sun, 08 Sep 2024, Krzysztof Kozlowski wrote: > On 07/09/2024 16:33, Junhao Xie wrote: > > On 2024/9/7 16:44, Markus Elfring wrote: > >> … > >>> +++ b/include/linux/mfd/photonicat-pmu.h > >>> @@ -0,0 +1,86 @@ > >> … > >>> +#ifndef _PHOTONICAT_PMU_H > >>> +#define _PHOTONICAT_PMU_H > >> … > >> > >> I suggest to omit leading underscores from such identifiers. > >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier > >> > >> Regards, > >> Markus > > > > Thanks for your suggestion, does this look better? > > #ifndef MFD_PHOTONICAT_PMU_H > > #define MFD_PHOTONICAT_PMU_H Yes, this is better. >
> Feel free to ignore all comments from Markus, regardless whether the > suggestion is reasonable or not. This person is banned from LKML and > several maintainers ignore Markus' feedback, because it is just a waste > of time. >
If you really _must_ do this, at least keep it factual. To the best of my knowledge Markus is not banned from LKML. -- Lee Jones [李琼斯]