From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/rtc:Fix the wrong format specifier
Date: Tue, 8 Oct 2024 11:54:43 +0200 [thread overview]
Message-ID: <20241008095443c9f8f39e@mail.local> (raw)
In-Reply-To: <20241008092517.14123-1-zhujun2@cmss.chinamobile.com>
Hello,
Please fix the subject line, it has to be in the subsystem style.
On 08/10/2024 02:25:17-0700, Zhu Jun wrote:
> The format specifier of "int" in sprintf() should be "%d", not
> "%u".
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
> drivers/rtc/rtc-rv3028.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
> index 2f001c59c61d..c79fad316119 100644
> --- a/drivers/rtc/rtc-rv3028.c
> +++ b/drivers/rtc/rtc-rv3028.c
> @@ -162,7 +162,7 @@ static ssize_t timestamp0_count_show(struct device *dev,
> if (ret)
> return ret;
>
> - return sprintf(buf, "%u\n", count);
> + return sprintf(buf, "%d\n", count);
> };
>
> static DEVICE_ATTR_RO(timestamp0_count);
> --
> 2.17.1
>
>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-10-08 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 9:25 [PATCH] drivers/rtc:Fix the wrong format specifier Zhu Jun
2024-10-08 9:54 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008095443c9f8f39e@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox