From: Lee Jones <lee@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: (subset) [PATCH] mfd: rtc: bd7xxxx Drop IC name from IRQ
Date: Thu, 10 Oct 2024 17:22:33 +0100 [thread overview]
Message-ID: <20241010162233.GH661995@google.com> (raw)
In-Reply-To: <2d48be5a-a259-4ab8-89dd-e662110d4d68@gmail.com>
On Thu, 10 Oct 2024, Matti Vaittinen wrote:
> On 09/10/2024 17:29, Lee Jones wrote:
> > On Thu, 26 Sep 2024 15:01:13 +0300, Matti Vaittinen wrote:
> > > A few ROHM PMICs have an RTC block which can be controlled by the
> > > rtc-bd70528 driver. The RTC driver needs the alarm interrupt information
> > > from the parent MFD driver. The MFD driver provides the interrupt
> > > information as a set of named interrupts, where the name is of form:
> > > <PMIC model>-rtc-alm-<x>, where x is an alarm block number.
> > >
> > > >From the RTC driver point of view it is irrelevant what the PMIC name
> > > is. It is sufficient to know this is alarm interrupt for a block X. The
> > > PMIC model information is carried to RTC via the platform device ID.
> > > Hence, having the PMIC model in the interrupt name is only making things
> > > more complex because the RTC driver needs to request differently named
> > > interrupts on different PMICs, making code unnecessary complicated.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] mfd: rtc: bd7xxxx Drop IC name from IRQ
> > commit: cd49b605779b4fea8224650eeba70b258c5cc8cc
>
> Hello Lee, Alexandre,
>
> Nothing pleases me more than having this quickly merged but...
> ... I don't think I saw ack from Alexandre yet. Furthermore, the (subset)
> makes me wonder because I sent RTC and MFD changes in a single patch - which
> might've been a mistake...
>
> I tried finding the cd49b605779b4fea8224650eeba70b258c5cc8cc from MFD tree
> and failed. Hence I'm a bit unsure where we are going.
Applying this was a key-binding mistake.
This was my real intention:
https://lore.kernel.org/all/20241009134416.GJ276481@google.com/
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-10-10 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 12:01 [PATCH] mfd: rtc: bd7xxxx Drop IC name from IRQ Matti Vaittinen
2024-10-09 13:44 ` Lee Jones
2024-10-31 14:27 ` Lee Jones
2024-10-09 14:29 ` (subset) " Lee Jones
2024-10-10 12:01 ` Matti Vaittinen
2024-10-10 16:22 ` Lee Jones [this message]
2024-10-10 16:23 ` Lee Jones
2024-10-31 17:22 ` Alexandre Belloni
2024-11-01 15:53 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010162233.GH661995@google.com \
--to=lee@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).