From: Lee Jones <lee@kernel.org>
To: Karel Balej <balejk@matfyz.cz>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
duje.mihanovic@skole.hr, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC
Date: Tue, 15 Oct 2024 09:35:30 +0100 [thread overview]
Message-ID: <20241015083530.GA8348@google.com> (raw)
In-Reply-To: <20241012193345.18594-2-balejk@matfyz.cz>
On Sat, 12 Oct 2024, Karel Balej wrote:
> RTC lives on the chip's base register page. Add the relevant register
> definitions and implement a basic set/read time functionality. Tested
> with the samsung,coreprimevelte smartphone which contains this PMIC and
> whose vendor kernel tree has also served as the sole reference for this.
>
> Signed-off-by: Karel Balej <balejk@matfyz.cz>
> ---
>
> Notes:
> RFC v2:
> - Move in the register definitions from the preceding patch and reword
> the commit message accordingly.
> - Rebase to v6.12-rc2.
>
> MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 10 ++++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-88pm886.c | 97 +++++++++++++++++++++++++++++++++++++
> include/linux/mfd/88pm886.h | 9 ++++
Acked-by: Lee Jones <lee@kernel.org>
> 5 files changed, 118 insertions(+)
> create mode 100644 drivers/rtc/rtc-88pm886.c
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-10-15 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 19:31 [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell Karel Balej
2024-10-12 19:31 ` [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC Karel Balej
2024-10-15 8:35 ` Lee Jones [this message]
2024-11-11 22:30 ` Alexandre Belloni
2024-11-11 22:38 ` (subset) " Alexandre Belloni
2024-10-15 8:36 ` [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell Lee Jones
2024-11-12 7:21 ` Karel Balej
2024-11-12 14:45 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015083530.GA8348@google.com \
--to=lee@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=balejk@matfyz.cz \
--cc=duje.mihanovic@skole.hr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).