From: Lee Jones <lee@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH] mfd: rtc: bd7xxxx Drop IC name from IRQ
Date: Thu, 31 Oct 2024 14:27:45 +0000 [thread overview]
Message-ID: <20241031142745.GG10824@google.com> (raw)
In-Reply-To: <20241009134416.GJ276481@google.com>
On Wed, 09 Oct 2024, Lee Jones wrote:
> On Thu, 26 Sep 2024, Matti Vaittinen wrote:
>
> > A few ROHM PMICs have an RTC block which can be controlled by the
> > rtc-bd70528 driver. The RTC driver needs the alarm interrupt information
> > from the parent MFD driver. The MFD driver provides the interrupt
> > information as a set of named interrupts, where the name is of form:
> > <PMIC model>-rtc-alm-<x>, where x is an alarm block number.
> >
> > From the RTC driver point of view it is irrelevant what the PMIC name
> > is. It is sufficient to know this is alarm interrupt for a block X. The
> > PMIC model information is carried to RTC via the platform device ID.
> > Hence, having the PMIC model in the interrupt name is only making things
> > more complex because the RTC driver needs to request differently named
> > interrupts on different PMICs, making code unnecessary complicated.
> >
> > Simplify this slightly by always using the RTC driver name 'bd70528' as
> > the prefix for alarm interrupts, no matter what the exact PMIC model is,
> > and always request the alarm interrupts of same name no matter what the
> > PMIC model is.
> >
> > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> >
> > ---
> > This contains both the RTC and MFD changes in order to not break the
> > functionality between commits to different subsystems.
>
> I can take it with an RTC Ack and an indication whether an immutable
> branch should be created and shared.
I fear this may have fallen from Alexandre's queue.
Please submit as a RESEND.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-10-31 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 12:01 [PATCH] mfd: rtc: bd7xxxx Drop IC name from IRQ Matti Vaittinen
2024-10-09 13:44 ` Lee Jones
2024-10-31 14:27 ` Lee Jones [this message]
2024-10-09 14:29 ` (subset) " Lee Jones
2024-10-10 12:01 ` Matti Vaittinen
2024-10-10 16:22 ` Lee Jones
2024-10-10 16:23 ` Lee Jones
2024-10-31 17:22 ` Alexandre Belloni
2024-11-01 15:53 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031142745.GG10824@google.com \
--to=lee@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).