From: Krzysztof Kozlowski <krzk@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: alexandre.belloni@bootlin.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] dt-bindings: rtc: pcf2127: Reference spi-peripheral-props.yaml
Date: Mon, 17 Mar 2025 12:06:36 +0100 [thread overview]
Message-ID: <20250317-robust-authentic-cassowary-0eb80b@krzk-bin> (raw)
In-Reply-To: <20250315124150.1853699-1-festevam@gmail.com>
On Sat, Mar 15, 2025 at 09:41:50AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Currently, when the 'spi-max-frequency' property is passed, the following
> dt-schema warning is seen:
>
> 'spi-max-frequency' does not match any of the regexes: 'pinctrl-[0-9]+'
Is this real or imaginary error? If imaginary, then do not include it
because it just confuses.
Otherwise: which Makefile target in upstream has this error?
>
> Fix it by adding a reference to spi-peripheral-props.yaml and change
> it to use 'unevaluatedProperties: false'.
You wrote 7 lines for something as simple as saying this is a SPI
device thus its binding should reference SPI device properties. Please
write concise and accurate commit msgs.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-03-17 11:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 12:41 [PATCH] dt-bindings: rtc: pcf2127: Reference spi-peripheral-props.yaml Fabio Estevam
2025-03-17 11:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317-robust-authentic-cassowary-0eb80b@krzk-bin \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox