[PATCH 0/7] rtc: drop unused module alias

[PATCH 0/7] rtc: drop unused module alias

[Johan Hovold]

When working on the pm8xxx driver I noticed that it had a platform
module alias while only supporting OF probe. This series drops it along
with unused aliases in the other RTC drivers.

Johan


Johan Hovold (7):
  rtc: at91rm9200: drop unused module alias
  rtc: cpcap: drop unused module alias
  rtc: da9063: drop unused module alias
  rtc: jz4740: drop unused module alias
  rtc: pm8xxx: drop unused module alias
  rtc: s3c: drop unused module alias
  rtc: stm32: drop unused module alias

 drivers/rtc/rtc-at91rm9200.c | 1 -
 drivers/rtc/rtc-cpcap.c      | 1 -
 drivers/rtc/rtc-da9063.c     | 1 -
 drivers/rtc/rtc-jz4740.c     | 1 -
 drivers/rtc/rtc-pm8xxx.c     | 1 -
 drivers/rtc/rtc-s3c.c        | 1 -
 drivers/rtc/rtc-stm32.c      | 1 -
 7 files changed, 7 deletions(-)

-- 
2.49.0

[PATCH 1/7] rtc: at91rm9200: drop unused module alias

[Johan Hovold]

The driver only support OF probe so drop the unused platform module
alias.

Fixes: 288d9cf1764a ("rtc: at91rm9200: use of_device_get_match_data()")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/rtc/rtc-at91rm9200.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index f6b0102a843a..643734dbae33 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -654,4 +654,3 @@ module_platform_driver_probe(at91_rtc_driver, at91_rtc_probe);
 MODULE_AUTHOR("Rick Bronson");
 MODULE_DESCRIPTION("RTC driver for Atmel AT91RM9200");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:at91_rtc");
-- 
2.49.0

Re: [PATCH 1/7] rtc: at91rm9200: drop unused module alias

[Krzysztof Kozlowski]

On 23/04/2025 15:03, Johan Hovold wrote:
> The driver only support OF probe so drop the unused platform module
> alias.
> 
> Fixes: 288d9cf1764a ("rtc: at91rm9200: use of_device_get_match_data()")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/7] rtc: cpcap: drop unused module alias

[Johan Hovold]

The driver only supports OF probe so drop the unused platform module
alias.

Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/rtc/rtc-cpcap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
index 568a89e79c11..c170345ac076 100644
--- a/drivers/rtc/rtc-cpcap.c
+++ b/drivers/rtc/rtc-cpcap.c
@@ -320,7 +320,6 @@ static struct platform_driver cpcap_rtc_driver = {
 
 module_platform_driver(cpcap_rtc_driver);
 
-MODULE_ALIAS("platform:cpcap-rtc");
 MODULE_DESCRIPTION("CPCAP RTC driver");
 MODULE_AUTHOR("Sebastian Reichel <sre@kernel.org>");
 MODULE_LICENSE("GPL");
-- 
2.49.0

Re: [PATCH 2/7] rtc: cpcap: drop unused module alias

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

Hi,

On Wed, Apr 23, 2025 at 03:03:13PM +0200, Johan Hovold wrote:
> The driver only supports OF probe so drop the unused platform module
> alias.
> 
> Fixes: dd3bf50b35e3 ("rtc: cpcap: new rtc driver")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/rtc/rtc-cpcap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c
> index 568a89e79c11..c170345ac076 100644
> --- a/drivers/rtc/rtc-cpcap.c
> +++ b/drivers/rtc/rtc-cpcap.c
> @@ -320,7 +320,6 @@ static struct platform_driver cpcap_rtc_driver = {
>  
>  module_platform_driver(cpcap_rtc_driver);
>  
> -MODULE_ALIAS("platform:cpcap-rtc");
>  MODULE_DESCRIPTION("CPCAP RTC driver");
>  MODULE_AUTHOR("Sebastian Reichel <sre@kernel.org>");
>  MODULE_LICENSE("GPL");
> -- 
> 2.49.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH 3/7] rtc: da9063: drop unused module alias

[Johan Hovold]

The driver only support OF probe so drop the unused platform module
alias.

Fixes: 80ca3277bc7f ("rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/rtc/rtc-da9063.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
index 859397541f29..38988d952db8 100644
--- a/drivers/rtc/rtc-da9063.c
+++ b/drivers/rtc/rtc-da9063.c
@@ -513,4 +513,3 @@ module_platform_driver(da9063_rtc_driver);
 MODULE_AUTHOR("S Twiss <stwiss.opensource@diasemi.com>");
 MODULE_DESCRIPTION("Real time clock device driver for Dialog DA9063");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:" DA9063_DRVNAME_RTC);
-- 
2.49.0

Re: [PATCH 3/7] rtc: da9063: drop unused module alias

[Krzysztof Kozlowski]

On 23/04/2025 15:03, Johan Hovold wrote:
> The driver only support OF probe so drop the unused platform module
> alias.
> 
> Fixes: 80ca3277bc7f ("rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 4/7] rtc: jz4740: drop unused module alias

[Johan Hovold]

The driver only support OF probe so drop the unused platform module
alias.

Fixes: 24e1f2c9383e ("rtc: ingenic: Only support probing from devicetree")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/rtc/rtc-jz4740.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
index 44bba356268c..11fce47be780 100644
--- a/drivers/rtc/rtc-jz4740.c
+++ b/drivers/rtc/rtc-jz4740.c
@@ -437,4 +437,3 @@ module_platform_driver(jz4740_rtc_driver);
 MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("RTC driver for the JZ4740 SoC\n");
-MODULE_ALIAS("platform:jz4740-rtc");
-- 
2.49.0

Re: [PATCH 4/7] rtc: jz4740: drop unused module alias

[Paul Cercueil]

Hi Johan,

Le mercredi 23 avril 2025 à 15:03 +0200, Johan Hovold a écrit :
> The driver only support OF probe so drop the unused platform module
> alias.
> 
> Fixes: 24e1f2c9383e ("rtc: ingenic: Only support probing from
> devicetree")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  drivers/rtc/rtc-jz4740.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> index 44bba356268c..11fce47be780 100644
> --- a/drivers/rtc/rtc-jz4740.c
> +++ b/drivers/rtc/rtc-jz4740.c
> @@ -437,4 +437,3 @@ module_platform_driver(jz4740_rtc_driver);
>  MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>");
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("RTC driver for the JZ4740 SoC\n");
> -MODULE_ALIAS("platform:jz4740-rtc");

[PATCH 5/7] rtc: pm8xxx: drop unused module alias

[Johan Hovold]

The driver only support OF probe so drop the unused platform module
alias.

Fixes: 5a418558cdae ("rtc: pm8xxx: add support for devicetree")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/rtc/rtc-pm8xxx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index 5da237e7b9b2..e624f848c22b 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -683,7 +683,6 @@ static struct platform_driver pm8xxx_rtc_driver = {
 
 module_platform_driver(pm8xxx_rtc_driver);
 
-MODULE_ALIAS("platform:rtc-pm8xxx");
 MODULE_DESCRIPTION("PMIC8xxx RTC driver");
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Anirudh Ghayal <aghayal@codeaurora.org>");
-- 
2.49.0

Re: [PATCH 5/7] rtc: pm8xxx: drop unused module alias

[Krzysztof Kozlowski]

On 23/04/2025 15:03, Johan Hovold wrote:
> The driver only support OF probe so drop the unused platform module
> alias.
> 
> Fixes: 5a418558cdae ("rtc: pm8xxx: add support for devicetree")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 6/7] rtc: s3c: drop unused module alias

[Johan Hovold]

The driver only support OF probe so drop the unused platform module
alias.

Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/rtc/rtc-s3c.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 58c957eb753d..5dd575865adf 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -609,4 +609,3 @@ module_platform_driver(s3c_rtc_driver);
 MODULE_DESCRIPTION("Samsung S3C RTC Driver");
 MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:s3c2410-rtc");
-- 
2.49.0

Re: [PATCH 6/7] rtc: s3c: drop unused module alias

[Krzysztof Kozlowski]

On 23/04/2025 15:03, Johan Hovold wrote:
> The driver only support OF probe so drop the unused platform module
> alias.
> 
> Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")

I believe this is not correct, but instead commit dropping last platform
user, which I think was:

Fixes: 0d297df03890 ("ARM: s3c: simplify platform code")


Just like in other patches here, these are old drivers and even if they
have OF matching method, they can be or they were modprobed via board files.

> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---


With the fixes tag fixed (to whatever commit dropping last platform user):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 6/7] rtc: s3c: drop unused module alias

[Johan Hovold]

On Tue, May 06, 2025 at 04:19:08PM +0200, Krzysztof Kozlowski wrote:
> On 23/04/2025 15:03, Johan Hovold wrote:
> > The driver only support OF probe so drop the unused platform module
> > alias.
> > 
> > Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")
> 
> I believe this is not correct, but instead commit dropping last platform
> user, which I think was:
> 
> Fixes: 0d297df03890 ("ARM: s3c: simplify platform code")

No, as I write in the commit message, the driver only supports OF probe
since the commit I refer to. It fails with -EINVAL and the following
error logged:

	failed getting s3c_rtc_data

for non-OF probe.

> Just like in other patches here, these are old drivers and even if they
> have OF matching method, they can be or they were modprobed via board files.

See above, similar reasoning applies for the other patches.

Johan

Re: [PATCH 6/7] rtc: s3c: drop unused module alias

[Krzysztof Kozlowski]

On 06/05/2025 16:35, Johan Hovold wrote:
> On Tue, May 06, 2025 at 04:19:08PM +0200, Krzysztof Kozlowski wrote:
>> On 23/04/2025 15:03, Johan Hovold wrote:
>>> The driver only support OF probe so drop the unused platform module
>>> alias.
>>>
>>> Fixes: ae05c95074e0 ("rtc: s3c: add s3c_rtc_data structure to use variant data instead of s3c_cpu_type")
>>
>> I believe this is not correct, but instead commit dropping last platform
>> user, which I think was:
>>
>> Fixes: 0d297df03890 ("ARM: s3c: simplify platform code")
> 
> No, as I write in the commit message, the driver only supports OF probe
> since the commit I refer to. It fails with -EINVAL and the following
> error logged:
> 
> 	failed getting s3c_rtc_data
> 
> for non-OF probe.

Haha, nice, so commit in 2014 nicely broke that platform's RTC.

There is one more thing: back in 2013-2015, I don't remember exactly,
the module loading/matching was not working with OF and you needed
aliases for the actual bus - platform or I2C. IIRC, the bus - platform
bus in this case - trigger uevent for module and then device match would
be via OF.

Anyway, this would be only for s3c2410 DT platform, because all others
(newer) use different compatible thus there would be no s3c2410-rtc
uevent for them.

Well, does not matter much, just sharing.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 7/7] rtc: stm32: drop unused module alias

[Johan Hovold]

The driver only support OF probe so drop the unused platform module
alias.

Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/rtc/rtc-stm32.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c
index 1b715db47160..ef8fb88aab48 100644
--- a/drivers/rtc/rtc-stm32.c
+++ b/drivers/rtc/rtc-stm32.c
@@ -1283,7 +1283,6 @@ static struct platform_driver stm32_rtc_driver = {
 
 module_platform_driver(stm32_rtc_driver);
 
-MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_AUTHOR("Amelie Delaunay <amelie.delaunay@st.com>");
 MODULE_DESCRIPTION("STMicroelectronics STM32 Real Time Clock driver");
 MODULE_LICENSE("GPL v2");
-- 
2.49.0

Re: [PATCH 7/7] rtc: stm32: drop unused module alias

[Krzysztof Kozlowski]

On 23/04/2025 15:03, Johan Hovold wrote:
> The driver only support OF probe so drop the unused platform module
> alias.
> 
> Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 0/7] rtc: drop unused module alias

[Johan Hovold]

Hi Alexandre,

On Wed, Apr 23, 2025 at 03:03:11PM +0200, Johan Hovold wrote:
> When working on the pm8xxx driver I noticed that it had a platform
> module alias while only supporting OF probe. This series drops it along
> with unused aliases in the other RTC drivers.

> Johan Hovold (7):
>   rtc: at91rm9200: drop unused module alias
>   rtc: cpcap: drop unused module alias
>   rtc: da9063: drop unused module alias
>   rtc: jz4740: drop unused module alias
>   rtc: pm8xxx: drop unused module alias
>   rtc: s3c: drop unused module alias
>   rtc: stm32: drop unused module alias

With the merge window around corner, could you pick these up for 6.16?

Johan

Re: [PATCH 0/7] rtc: drop unused module alias

[Alexandre Belloni]

On Wed, 23 Apr 2025 15:03:11 +0200, Johan Hovold wrote:
> When working on the pm8xxx driver I noticed that it had a platform
> module alias while only supporting OF probe. This series drops it along
> with unused aliases in the other RTC drivers.
> 
> Johan
> 
> 
> [...]

Applied, thanks!

[1/7] rtc: at91rm9200: drop unused module alias
      https://git.kernel.org/abelloni/c/9f05c3943eb6
[2/7] rtc: cpcap: drop unused module alias
      https://git.kernel.org/abelloni/c/5f28ab049fb3
[3/7] rtc: da9063: drop unused module alias
      https://git.kernel.org/abelloni/c/ac45f6e2473b
[4/7] rtc: jz4740: drop unused module alias
      https://git.kernel.org/abelloni/c/c61f165617b1
[5/7] rtc: pm8xxx: drop unused module alias
      https://git.kernel.org/abelloni/c/d5e85c8bfaa6
[6/7] rtc: s3c: drop unused module alias
      https://git.kernel.org/abelloni/c/149834a414e1
[7/7] rtc: stm32: drop unused module alias
      https://git.kernel.org/abelloni/c/3639b35857e2

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com