* [PATCH AUTOSEL 6.6 064/294] rtc: rv3032: fix EERD location [not found] <20250505225634.2688578-1-sashal@kernel.org> @ 2025-05-05 22:52 ` Sasha Levin 2025-05-05 22:53 ` [PATCH AUTOSEL 6.6 109/294] rtc: ds1307: stop disabling alarms on probe Sasha Levin 1 sibling, 0 replies; 2+ messages in thread From: Sasha Levin @ 2025-05-05 22:52 UTC (permalink / raw) To: linux-kernel, stable; +Cc: Alexandre Belloni, Sasha Levin, linux-rtc From: Alexandre Belloni <alexandre.belloni@bootlin.com> [ Upstream commit b0f9cb4a0706b0356e84d67e48500b77b343debe ] EERD is bit 2 in CTRL1 Link: https://lore.kernel.org/r/20250306214243.1167692-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/rtc/rtc-rv3032.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3032.c b/drivers/rtc/rtc-rv3032.c index 35b2e36b426a0..cb01038a2e27f 100644 --- a/drivers/rtc/rtc-rv3032.c +++ b/drivers/rtc/rtc-rv3032.c @@ -69,7 +69,7 @@ #define RV3032_CLKOUT2_FD_MSK GENMASK(6, 5) #define RV3032_CLKOUT2_OS BIT(7) -#define RV3032_CTRL1_EERD BIT(3) +#define RV3032_CTRL1_EERD BIT(2) #define RV3032_CTRL1_WADA BIT(5) #define RV3032_CTRL2_STOP BIT(0) -- 2.39.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH AUTOSEL 6.6 109/294] rtc: ds1307: stop disabling alarms on probe [not found] <20250505225634.2688578-1-sashal@kernel.org> 2025-05-05 22:52 ` [PATCH AUTOSEL 6.6 064/294] rtc: rv3032: fix EERD location Sasha Levin @ 2025-05-05 22:53 ` Sasha Levin 1 sibling, 0 replies; 2+ messages in thread From: Sasha Levin @ 2025-05-05 22:53 UTC (permalink / raw) To: linux-kernel, stable; +Cc: Alexandre Belloni, Sasha Levin, linux-rtc From: Alexandre Belloni <alexandre.belloni@bootlin.com> [ Upstream commit dcec12617ee61beed928e889607bf37e145bf86b ] It is a bad practice to disable alarms on probe or remove as this will prevent alarms across reboots. Link: https://lore.kernel.org/r/20250303223744.1135672-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/rtc/rtc-ds1307.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 506b7d1c23970..0c78451960926 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1802,10 +1802,8 @@ static int ds1307_probe(struct i2c_client *client) * For some variants, be sure alarms can trigger when we're * running on Vbackup (BBSQI/BBSQW) */ - if (want_irq || ds1307_can_wakeup_device) { + if (want_irq || ds1307_can_wakeup_device) regs[0] |= DS1337_BIT_INTCN | chip->bbsqi_bit; - regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE); - } regmap_write(ds1307->regmap, DS1337_REG_CONTROL, regs[0]); -- 2.39.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-05 23:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250505225634.2688578-1-sashal@kernel.org>
2025-05-05 22:52 ` [PATCH AUTOSEL 6.6 064/294] rtc: rv3032: fix EERD location Sasha Levin
2025-05-05 22:53 ` [PATCH AUTOSEL 6.6 109/294] rtc: ds1307: stop disabling alarms on probe Sasha Levin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).