From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Harini T <harini.t@amd.com>
Cc: michal.simek@amd.com, linux-rtc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH] rtc: zynqmp: Add shutdown callback for kexec support
Date: Fri, 25 Jul 2025 01:55:27 +0200 [thread overview]
Message-ID: <2025072423552753300d57@mail.local> (raw)
In-Reply-To: <20250724170517.974356-1-harini.t@amd.com>
On 24/07/2025 22:35:17+0530, Harini T wrote:
> During kexec, the hardware is not reset and any enabled interrupts can
> interfere with the new kernel's RTC initialization.
Please elaborate on the issue because alarm are supposed to stay enabled across
reboots, this is the whole point of the RTC.
>
> The shutdown callback reuses the existing remove function to disable
> alarm interrupts and wakeup capability, putting the device in a
> quiescent state rather than completely removing it.
>
> Signed-off-by: Harini T <harini.t@amd.com>
> ---
> drivers/rtc/rtc-zynqmp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-zynqmp.c b/drivers/rtc/rtc-zynqmp.c
> index f39102b66eac..26893367f0f5 100644
> --- a/drivers/rtc/rtc-zynqmp.c
> +++ b/drivers/rtc/rtc-zynqmp.c
> @@ -383,6 +383,7 @@ MODULE_DEVICE_TABLE(of, xlnx_rtc_of_match);
> static struct platform_driver xlnx_rtc_driver = {
> .probe = xlnx_rtc_probe,
> .remove = xlnx_rtc_remove,
> + .shutdown = xlnx_rtc_remove,
> .driver = {
> .name = KBUILD_MODNAME,
> .pm = &xlnx_rtc_pm_ops,
> --
> 2.43.0
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-07-24 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 17:05 [PATCH] rtc: zynqmp: Add shutdown callback for kexec support Harini T
2025-07-24 23:55 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072423552753300d57@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=git@amd.com \
--cc=harini.t@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).