From: Arnd Bergmann <arnd@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Antoni Pokusinski <apokusinski01@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Lukas Stockmann <lukas.stockmann@siemens.com>,
Maud Spierings <maudspierings@gocontroll.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] rtc: pcf85063: hide an unused variable
Date: Fri, 25 Jul 2025 11:07:06 +0200 [thread overview]
Message-ID: <20250725090709.2505113-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The newly introduced configuration is only used by code that is
inside of an #ifdef block, cauing a warning when that block is
disabled by the configuration is still there:
drivers/rtc/rtc-pcf85063.c:566:37: error: 'config_rv8063' defined but not used [-Werror=unused-const-variable=]
Add the same #ifdef here.
Fixes: a3c7f7e16ea8 ("rtc: pcf85063: add support for RV8063")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/rtc/rtc-pcf85063.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index d9b67b959d18..41e4a5a16574 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -563,6 +563,7 @@ static const struct pcf85063_config config_rv8263 = {
.force_cap_7000 = 1,
};
+#if IS_ENABLED(CONFIG_SPI_MASTER)
static const struct pcf85063_config config_rv8063 = {
.regmap = {
.reg_bits = 8,
@@ -574,6 +575,7 @@ static const struct pcf85063_config config_rv8063 = {
.has_alarms = 1,
.force_cap_7000 = 1,
};
+#endif
static int pcf85063_probe(struct device *dev, struct regmap *regmap, int irq,
const struct pcf85063_config *config)
--
2.39.5
next reply other threads:[~2025-07-25 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 9:07 Arnd Bergmann [this message]
2025-08-15 21:36 ` [PATCH] rtc: pcf85063: hide an unused variable Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725090709.2505113-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=alexander.sverdlin@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=apokusinski01@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lukas.stockmann@siemens.com \
--cc=maudspierings@gocontroll.com \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).