From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0E916F265; Tue, 2 Sep 2025 10:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756808441; cv=none; b=lxbadKfEZdUsswLk56qwzOb/eJvLYetnsJHjOTbQU5GLl+odVqLgg4PrGwL9Ixd1ktsKychpu92Vbbq01whP9JchQPDTyGzjEfktwfIpR/o8ObU4yzJEGD/nX1IxMZUv2BBvcqEuV3gV4mcGTZk7RCkfvTuJ0zuiR8rN3HyRDrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756808441; c=relaxed/simple; bh=cKYY4/cnGdSxn6qpOUZOPp0+KPQ/VT0Yziv6NOtZK0c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HWV6Ft05FoiA7AMm94vXPQjCT2x2tjWmKh5cjDPacYdn7yDhoSjzLruJO8dFamnmHhSbId555z7K85ZafFwtczPyQfsVW0umuGMCmKewGI82asSAOp3FsA+nfZ7CHg58RtkOnOEVHtniJlFCKREyhxOgraOJ0MEzJOB0W4OJ+ZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=saf5HSS1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="saf5HSS1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EBB4C4CEF5; Tue, 2 Sep 2025 10:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756808441; bh=cKYY4/cnGdSxn6qpOUZOPp0+KPQ/VT0Yziv6NOtZK0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=saf5HSS1u3W7YVadb9lNs7hBvFfHkmwEIZCsnq+VSLREzpGCL+JNG/jiGhct2MSik 6Smur6hyPC2wAaEjcvpYg28jGBMTLjtfXsbaEsQel44sMeJGiJiodTQSXFWMNH89aZ zYYKoiizs0fIyDN72ke2BuFsztFoVTs32Ej8RZzPumEmQX0djdrbpIOB5rAk9RFN79 3xkCSSpPigKjPDNOF9tVqQC1M+qBkYInhPfEi3KKJSTg914LCnUkSK029wkkj1+gfl QkRWEk5Ff8qGkQtw0evPKUeoXzjBK3krnM/42sYYMilrOVOWlMwzjh2a1Ri8nYbDSb xrLW9nm503hqQ== Date: Tue, 2 Sep 2025 11:20:36 +0100 From: Lee Jones To: Alexander Kurz Cc: Alexandre Belloni , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-input@vger.kernel.or, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH] Drivers: mc13783: remove deprecated mc13xxx_irq_ack() Message-ID: <20250902102036.GE2163762@google.com> References: <20250811064358.1659-1-akurz@blala.de> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250811064358.1659-1-akurz@blala.de> On Mon, 11 Aug 2025, Alexander Kurz wrote: > mc13xxx_irq_ack() got deprecated and became dead code with commit > 10f9edaeaa30 ("mfd: mc13xxx: Use regmap irq framework for interrupts"). > It should be safe to remove it now. > > Signed-off-by: Alexander Kurz > --- > drivers/input/misc/mc13783-pwrbutton.c | 1 - > drivers/input/touchscreen/mc13783_ts.c | 4 ---- > drivers/rtc/rtc-mc13xxx.c | 13 ------------- RTC review / Ack please. > include/linux/mfd/mc13xxx.h | 6 ------ > 4 files changed, 24 deletions(-) > > diff --git a/drivers/input/misc/mc13783-pwrbutton.c b/drivers/input/misc/mc13783-pwrbutton.c > index 1c7faa9b7afe..b83d762ae2e9 100644 > --- a/drivers/input/misc/mc13783-pwrbutton.c > +++ b/drivers/input/misc/mc13783-pwrbutton.c > @@ -57,7 +57,6 @@ static irqreturn_t button_irq(int irq, void *_priv) > struct mc13783_pwrb *priv = _priv; > int val; > > - mc13xxx_irq_ack(priv->mc13783, irq); > mc13xxx_reg_read(priv->mc13783, MC13783_REG_INTERRUPT_SENSE_1, &val); > > switch (irq) { > diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c > index 33635da85079..47b8da00027f 100644 > --- a/drivers/input/touchscreen/mc13783_ts.c > +++ b/drivers/input/touchscreen/mc13783_ts.c > @@ -42,8 +42,6 @@ static irqreturn_t mc13783_ts_handler(int irq, void *data) > { > struct mc13783_ts_priv *priv = data; > > - mc13xxx_irq_ack(priv->mc13xxx, irq); > - > /* > * Kick off reading coordinates. Note that if work happens already > * be queued for future execution (it rearms itself) it will not > @@ -137,8 +135,6 @@ static int mc13783_ts_open(struct input_dev *dev) > > mc13xxx_lock(priv->mc13xxx); > > - mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_TS); > - > ret = mc13xxx_irq_request(priv->mc13xxx, MC13XXX_IRQ_TS, > mc13783_ts_handler, MC13783_TS_NAME, priv); > if (ret) > diff --git a/drivers/rtc/rtc-mc13xxx.c b/drivers/rtc/rtc-mc13xxx.c > index e7b87130e624..2494d13fd767 100644 > --- a/drivers/rtc/rtc-mc13xxx.c > +++ b/drivers/rtc/rtc-mc13xxx.c > @@ -137,10 +137,6 @@ static int mc13xxx_rtc_set_time(struct device *dev, struct rtc_time *tm) > } > > if (!priv->valid) { > - ret = mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_RTCRST); > - if (unlikely(ret)) > - goto out; > - > ret = mc13xxx_irq_unmask(priv->mc13xxx, MC13XXX_IRQ_RTCRST); > } > > @@ -208,10 +204,6 @@ static int mc13xxx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) > if (unlikely(ret)) > goto out; > > - ret = mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_TODA); > - if (unlikely(ret)) > - goto out; > - > s1970 = rtc_tm_to_time64(&alarm->time); > > dev_dbg(dev, "%s: %s %lld\n", __func__, alarm->enabled ? "on" : "off", > @@ -239,12 +231,9 @@ static int mc13xxx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) > static irqreturn_t mc13xxx_rtc_alarm_handler(int irq, void *dev) > { > struct mc13xxx_rtc *priv = dev; > - struct mc13xxx *mc13xxx = priv->mc13xxx; > > rtc_update_irq(priv->rtc, 1, RTC_IRQF | RTC_AF); > > - mc13xxx_irq_ack(mc13xxx, irq); > - > return IRQ_HANDLED; > } > > @@ -293,8 +282,6 @@ static int __init mc13xxx_rtc_probe(struct platform_device *pdev) > > mc13xxx_lock(mc13xxx); > > - mc13xxx_irq_ack(mc13xxx, MC13XXX_IRQ_RTCRST); > - > ret = mc13xxx_irq_request(mc13xxx, MC13XXX_IRQ_RTCRST, > mc13xxx_rtc_reset_handler, DRIVER_NAME, priv); > if (ret) > diff --git a/include/linux/mfd/mc13xxx.h b/include/linux/mfd/mc13xxx.h > index f372926d5894..dd46fe424a80 100644 > --- a/include/linux/mfd/mc13xxx.h > +++ b/include/linux/mfd/mc13xxx.h > @@ -31,12 +31,6 @@ int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, > unsigned int mode, unsigned int channel, > u8 ato, bool atox, unsigned int *sample); > > -/* Deprecated calls */ > -static inline int mc13xxx_irq_ack(struct mc13xxx *mc13xxx, int irq) > -{ > - return 0; > -} > - > static inline int mc13xxx_irq_request_nounmask(struct mc13xxx *mc13xxx, int irq, > irq_handler_t handler, > const char *name, void *dev) > -- > 2.39.5 > -- Lee Jones [李琼斯]