From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9426A27B352 for ; Mon, 22 Sep 2025 14:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758552187; cv=none; b=DSA6PceNmDztwGOJ9iE2oWjI6g0kxboO7vrQynLLnJEWM27Ic/VxmBnjYZA1yn8a7Xj5jAs7CsFhWGB/9dNE/RjuqO4tZEsyzLzZi4xhxQwUg5k/banBtQioJb3cZphoCq0BisuXsju9DdbroXFMp3Se4FpQDFjU70SLNqseAQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758552187; c=relaxed/simple; bh=GNd0y4cVbWPetSA78wepeAR7zoMfnuBG+rjT2H3cUJA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iBb5cmeSAUfkLD0LTY0jaZgIYjSHy3JeF8f5b8W0TYnjsS/9rvctOfJiKa+cfPboGnZ4gLOV0mZ675emkDS8D5VmVv6K2iVB/L0WoTokge0+pYfQHq68nJk/LbCPRPjKomFf4XEEKy0U2rh4oG1GBB2Mbz7eJg9bom6o0LvL77o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bq45ijOg; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bq45ijOg" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-362acd22c78so37872811fa.2 for ; Mon, 22 Sep 2025 07:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758552184; x=1759156984; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MtIdBcXjvQm0npfMBQTkmT+Qi8zM6Vw8hQsMj63CDrk=; b=bq45ijOgAmprZnywT9pQa4Os54Gc44xFaAHmLAwbL/7fvG2rR1EFAhdcvhfiVQPF4R QZ6/Dmx+6D/eCeKSWEq4oW5ARx7fLihN6aI5PFjr5gQvDM8RugKIfSdNKJSfR4KbAQ4b cNozQm6aiPcWRLG23ktDWtfx7DFoZJkGjBLEc78+cdpIZNWFmk2hxHItnJFf5+KXH83K WsM7zV6gNNic9JNsfgyPLbY+skaQg40+6Jd2ThqVznDWkd8d3C26lFtwrtGEuZ8d9LK3 Yi+FnNjAY99alx6nGy/vNqKZgoZBlkTRNDhxtaayMGY9ujGknln517P5cJaExfh9oqP+ uWLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758552184; x=1759156984; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MtIdBcXjvQm0npfMBQTkmT+Qi8zM6Vw8hQsMj63CDrk=; b=fx6o9eguW5ZT4m/Lpy2p2Fs2VR3BM3daWHyRyYEfrLvTxGFImo2N5G9r5BHLDSYvDa ONJNUTi5nuYD+4tjOQz8iuIYpCmrmIBLTRKCt1WRf9KJisNz2Vp61NRZEI+RFBMrNa5y j9eOw7AGWnhti9ER8iWjUL4M5u2lEj1ayHxRkG50AhRs3PKdqQQqZQnpzi1YU2i3J1oD mxNUdMt8f+KmP6JvNsegD8fVmJS1xMZ3EKXikEyJiryLCjRpy3Z4+tFEwAY6OSofKvSt xHXSSPrU9KN/W9mQoUWC5rQTYfg72FkLwZ2nd+ImeweRmvJH3ugJhFh03qDkcn/ZBz9k 0QlA== X-Forwarded-Encrypted: i=1; AJvYcCVH+cGlIKE5D5eYRqj7aDbji3cFpgfYufMPwdICwHbC8h1a015hS2SnmI+rUorFWY/lcXnkViLnLt8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2jMVTKa64dcG09Hr3XVGJ9zMOka8hhhc/XSgPJv0jYxluY3Fm q9yjhEmdOQaVvOjmslYQSglQHpPU/7+3CKFuZ42u7vlQRAojRVObAR6Ppemc+0oz X-Gm-Gg: ASbGnctDegfFHZuSUqcCX35GWNyihre1rjqqkOC8MJ1yIALJVBrTWb6sir1GcxKGrXd rO00m274ImX39nkhwEN9coKovKX28BDLBJvyXQhrNMQT6oxSppvtfWJsg7/C06FKjZhhlt+aNGg wS9t4cwKlyW9+SkGrccpDp0GbTGMQeBiSNZWvOHjJyq3NzPZdz9tGCe13+395w1wbkn69L01bMr Nws9zJXUNt6H15MQLrTSfOdWiz+P6U39KIEEVfatzVjWLkKXAQuvKOT2cQzzdo3p9UIaRuClY1Y qbftjQj7tqBnKIRb8b3MZHPT/VccIFiJRfHqQhXTYgnhurSL4fjnQ+X89HIR44DP5b3OVlGQuh/ 69zuB5lmVOYP0CzC+wTUTgZLb5h/i6askZxPjgaukwuqmIr8JtrzwwPtn1vAw2JDJTp90/Zaz1J nLNRzQN0fWpDIaS6/q X-Google-Smtp-Source: AGHT+IEyiePhldEEUbZLhZdpleCuDyBFXuJfswMLKkVPADF+9ubU/JrFMn02YfNheZiFsLVEtydyuw== X-Received: by 2002:a05:651c:4413:20b0:360:3fc1:28a3 with SMTP id 38308e7fff4ca-36418ed0e80mr31697991fa.38.1758552183370; Mon, 22 Sep 2025 07:43:03 -0700 (PDT) Received: from localhost.localdomain (broadband-109-173-93-221.ip.moscow.rt.ru. [109.173.93.221]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-361a25d7309sm30492541fa.15.2025.09.22.07.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 07:43:03 -0700 (PDT) From: Alexandr Sapozhnkiov To: Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexandr Sapozhnikov , linux-media@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH 5.10] rtc: fix error return in pm80x_rtc_set_alarm() Date: Mon, 22 Sep 2025 17:42:58 +0300 Message-ID: <20250922144300.11-1-alsp705@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alexandr Sapozhnikov Return value of function 'regmap_raw_write', called at rtc-88pm80x.c:205, is not checked, but it is usually checked for this function Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Alexandr Sapozhnikov --- drivers/rtc/rtc-88pm80x.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c index f40cc06b0979..82984a58dca7 100644 --- a/drivers/rtc/rtc-88pm80x.c +++ b/drivers/rtc/rtc-88pm80x.c @@ -173,7 +173,7 @@ static int pm80x_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) struct rtc_time now_tm, alarm_tm; unsigned long ticks, base, data; unsigned char buf[4]; - int mask; + int mask, ret; regmap_update_bits(info->map, PM800_RTC_CONTROL, PM800_ALARM1_EN, 0); @@ -202,7 +202,9 @@ static int pm80x_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) buf[1] = (data >> 8) & 0xff; buf[2] = (data >> 16) & 0xff; buf[3] = (data >> 24) & 0xff; - regmap_raw_write(info->map, PM800_RTC_EXPIRE1_1, buf, 4); + ret = regmap_raw_write(info->map, PM800_RTC_EXPIRE1_1, buf, 4); + if (ret) + return ret; if (alrm->enabled) { mask = PM800_ALARM | PM800_ALARM_WAKEUP | PM800_ALARM1_EN; regmap_update_bits(info->map, PM800_RTC_CONTROL, mask, mask); -- 2.43.0