From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96862F5A11 for ; Thu, 2 Oct 2025 09:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759396618; cv=none; b=puIZ3XuYlqTeScK6mCsdeP6K4eHLIJslmATg7tXLpcjLkAu7B699VOfVzE+K5qur5sUb1VUjhsWBl8URiwScalcEKGsThwh8IrWZY278SF0O/yK47KNX9KodWr51yrpoEOFvhnqa+hbVJx1D7NJY5M61jCHms8QM2K+t7EDPkBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759396618; c=relaxed/simple; bh=3ONPV3iuwid4tuzGNY1hJ25itYLRoKeEE5z0jRpe1s0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SQQxzrz1Vw+calbRf2tD2vlZY01IT++Xb202Q6IhGQ4uEAcfE9Cc/mAmuV6XlUPAJ5KotqQfy1XqU0Z9vcAxFfIl8wvvZcSlxtoC7GwwFifK8/r7qEVzfg2J7Wak1PxvquywJGcvmuMKWGx095khDV6n1xNAzAclIr+MGlkaUj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NSuBz+7k; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NSuBz+7k" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-58984c363ceso1788354e87.0 for ; Thu, 02 Oct 2025 02:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759396615; x=1760001415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ApE4Y9HHVTXtvFDXr6NgsDg4wKfmns1sAEMuzKFX5eQ=; b=NSuBz+7kxTNA6cTwHprDO6InEQpF3dNPwmgq1UbWojdvF3YusVotctn3ulevUeFMJA UgcUUod6WfFajGEbNjGHI1HIsS8pTE38QLN2OY+g8mdFXmbwI3RtJhhp9NEK35pCYe55 2Qp2CPqHfaPnRHqczAsDX4bKT1R7jn7pBVW3kvB7sm2MdRya04ErFk5v+o87q3JsHUY4 jsSnrPKlUZeWZ5Taw7Jk9+HnIGs63at3XA4e7XjSACmUxSgJ6vz7ETMx34DtoxsmFTn0 3uZH+3RzszKfE6A0Zbhr1n4lff/rzGaD5TPrGJU2Cm9mLDrbNNYBj6AuPfrpMiGO053q WY7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759396615; x=1760001415; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ApE4Y9HHVTXtvFDXr6NgsDg4wKfmns1sAEMuzKFX5eQ=; b=EJiLBLrzatPkFPiYxEyBd561pcdfCXfdI4frBh0fDQor60MLAgjd/ZIqumU9RGCzcA l6KGPFsrS1AqvsUty2jnFr09xnseH/D9EuJ01Qsq8bU5u5EOLIJiS7xL3FniDGKAoJ6T F1QPPJ71w5u0/qRfmn95GGx72hW6wuOmFGAnkyVzJy4JPB/1OyoHyB5LMjeK1q01N9f2 q9krZy7HSisAeBgQUWE7Gw4P67a1FTPkN0gLNLfJTDWDCMcMwd2Y7BrgbJvSVA/ESST/ HLarq59LZRftnxXBP8az3kU3HbQpdqbZ4RGGyzD+zuMLrvDuSdv04uyioB7DDKN//hmZ fGyA== X-Forwarded-Encrypted: i=1; AJvYcCXCFvTTtS2zHcyc5xY01p1D7QeQmje6xvCkZ/NisVwFqSoBeCRKg1yvN+Gg0fQ3s+L5Jed3nUXiq78=@vger.kernel.org X-Gm-Message-State: AOJu0YzgU1guluUJBsfkz6AysO226xcylIvdwtx9upFbxwwuflxf/Nhq uEXKmTN/Qb1tHqXBi2aDbkc5CH4+F4qActJhWE8zxKbS1uVW16rLPFAq X-Gm-Gg: ASbGncuPo+GkHUfQp9inNYqpFXheYqV9esIrGkHFKVyrg5XJkaO2t+Dt+v+FsrHRfN2 Ckfw/MPyvH7IrmKMt/MFIp5Q7JnhabSl1uHFXgqlF/erA4amn5UYvyZ2IDu1sgCd//box4G5vK/ phwgyWMlLKaXLJMn6Fiuhmi0LJPLAffnmdY7m9Gy/3KmymOST/rCZR9xW7lrCvEcne/Su0A0pAy 741RSnGobz5xKPA4bKwOCt/jnrjbVJ+2gHhtsFNVrUKrgVzeFPin5Uoy5Ij6do/jhF3K+B8Iiti V4J9ViePXhS8x5OaGYR4ZGh48bp1xE19v6BHO2yt9Spa8HrVeF3AzuscJCWXTvcwbWq9hlyrW6q nKXi0FG5bX9ulhAmK5mhlKNbxj7Ig/8aPUO6+/rtBq7UcUMmxjXiIHSV7Ye3dMBb65UZEXdvr1F d5jI7R/5X/GgMl/G8jPic+WOHd0p+g6b/Un8uszoQu X-Google-Smtp-Source: AGHT+IEgvHumXKmVR0wOfKwUqlKjQ3ss2VADqHWOC1c5n35kevdUmjMy4wkE5Pu8uNHrZooblrPdLg== X-Received: by 2002:a05:6512:401a:b0:58a:ff9b:2234 with SMTP id 2adb3069b0e04-58b00b3d66amr944937e87.2.1759396614697; Thu, 02 Oct 2025 02:16:54 -0700 (PDT) Received: from localhost.localdomain (broadband-109-173-93-221.ip.moscow.rt.ru. [109.173.93.221]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0113ed8dsm666665e87.44.2025.10.02.02.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 02:16:54 -0700 (PDT) From: Alexandr Sapozhnkiov To: Alexandre Belloni , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexandr Sapozhnikov , lvc-project@linuxtesting.org Subject: [PATCH] rtc: fix error return in pm80x_rtc_set_alarm() Date: Thu, 2 Oct 2025 12:16:49 +0300 Message-ID: <20251002091651.11-1-alsp705@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alexandr Sapozhnikov The regmap_raw_read() function may return an error. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Alexandr Sapozhnikov --- drivers/rtc/rtc-88pm80x.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c index f40cc06b0979..f26d8a1e827b 100644 --- a/drivers/rtc/rtc-88pm80x.c +++ b/drivers/rtc/rtc-88pm80x.c @@ -173,17 +173,21 @@ static int pm80x_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) struct rtc_time now_tm, alarm_tm; unsigned long ticks, base, data; unsigned char buf[4]; - int mask; + int mask, ret; regmap_update_bits(info->map, PM800_RTC_CONTROL, PM800_ALARM1_EN, 0); - regmap_raw_read(info->map, PM800_RTC_EXPIRE2_1, buf, 4); + ret = regmap_raw_read(info->map, PM800_RTC_EXPIRE2_1, buf, 4); + if (ret) + return ret; base = ((unsigned long)buf[3] << 24) | (buf[2] << 16) | (buf[1] << 8) | buf[0]; dev_dbg(info->dev, "%x-%x-%x-%x\n", buf[0], buf[1], buf[2], buf[3]); /* load 32-bit read-only counter */ - regmap_raw_read(info->map, PM800_RTC_COUNTER1, buf, 4); + ret = regmap_raw_read(info->map, PM800_RTC_COUNTER1, buf, 4); + if (ret) + return ret; data = ((unsigned long)buf[3] << 24) | (buf[2] << 16) | (buf[1] << 8) | buf[0]; ticks = base + data; -- 2.43.0