linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Will McVicker <willmcvicker@google.com>,
	Juan Yescas <jyescas@google.com>,
	Douglas Anderson <dianders@chromium.org>,
	kernel-team@android.com,
	Kaustabh Chakraborty <kauschluss@disroot.org>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH 0/3] Samsung mfd/rtc driver alarm IRQ simplification
Date: Thu, 20 Nov 2025 10:31:04 +0000	[thread overview]
Message-ID: <20251120103104.GY1949330@google.com> (raw)
In-Reply-To: <20251114-s5m-alarm-v1-0-c9b3bebae65f@linaro.org>

On Fri, 14 Nov 2025, André Draszik wrote:

> Hi,
> 
> With the attached patches the Samsung s5m RTC driver is simplified a
> little bit with regards to alarm IRQ acquisition.
> 
> The end result is that instead of having a list of IRQ numbers for each
> variant (and a BUILD_BUG_ON() to ensure consistency), the RTC driver
> queries the 'alarm' platform resource from the parent (mfd cell).
> 
> Additionally, we can drop a now-useless field from runtime data,
> reducing memory consumption slightly.
> 
> The attached patches must be applied in-order. I would expect them all
> to go via the MFD tree. Alternatively, they could be applied one after
> another during multiple kernel release cycles, but that seems a
> needless complication.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> André Draszik (3):
>       mfd: sec: add rtc alarm IRQ as platform device resource
>       rtc: s5m: query platform device IRQ resource for alarm IRQ
>       mfd: sec: drop now unused struct sec_pmic_dev::irq_data
> 
>  drivers/mfd/sec-common.c         | 41 ++++++++++++++++++++++++++++++----------
>  drivers/mfd/sec-core.h           |  2 +-
>  drivers/mfd/sec-irq.c            | 10 ++--------
>  drivers/rtc/rtc-s5m.c            | 21 ++++++++------------
>  include/linux/mfd/samsung/core.h |  1 -
>  5 files changed, 42 insertions(+), 33 deletions(-)

This needs to be rebased now, right?

-- 
Lee Jones [李琼斯]

  parent reply	other threads:[~2025-11-20 10:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 11:47 [PATCH 0/3] Samsung mfd/rtc driver alarm IRQ simplification André Draszik
2025-11-14 11:47 ` [PATCH 1/3] mfd: sec: add rtc alarm IRQ as platform device resource André Draszik
2025-11-14 11:47 ` [PATCH 2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ André Draszik
2025-11-14 15:58   ` Alexandre Belloni
2025-11-14 11:47 ` [PATCH 3/3] mfd: sec: drop now unused struct sec_pmic_dev::irq_data André Draszik
2025-11-20 10:35   ` Lee Jones
2025-11-20 14:38     ` André Draszik
2025-11-20 10:31 ` Lee Jones [this message]
2025-11-20 10:32   ` [PATCH 0/3] Samsung mfd/rtc driver alarm IRQ simplification André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120103104.GY1949330@google.com \
    --to=lee@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andre.draszik@linaro.org \
    --cc=dianders@chromium.org \
    --cc=jyescas@google.com \
    --cc=kauschluss@disroot.org \
    --cc=kernel-team@android.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).