From: Krzysztof Kozlowski <krzk@kernel.org>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: rtc: isl12026: convert to YAML schema
Date: Sat, 28 Feb 2026 11:40:05 +0100 [thread overview]
Message-ID: <20260228-classy-sexy-sponge-dba71b@quoll> (raw)
In-Reply-To: <20260227185115.174997-1-piyushpatle228@gmail.com>
On Sat, Feb 28, 2026 at 12:21:15AM +0530, Piyush Patle wrote:
> Convert the ISL12026 RTC binding from text format to YAML schema.
> Remove the legacy text binding.
>
> The new schema enables dtbs_check validation.
>
> Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
> ---
>
> Changes in v3:
> - Removed unsupported select section
>
> Changes in v2:
> - Fixed dt_binding_check warnings
> - Improved example formatting
>
> Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
Duplicate signature. Please run scripts/checkpatch.pl on the patches and
fix reported warnings. After that, run also 'scripts/checkpatch.pl
--strict' on the patches and (probably) fix more warnings. Some warnings
can be ignored, especially from --strict run, but the code here looks
like it needs a fix. Feel free to get in touch if the warning is not
clear.
Rest is fine and duplicated SoB might be just ignored due to cut
separator.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-28 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 18:51 [PATCH v3] dt-bindings: rtc: isl12026: convert to YAML schema Piyush Patle
2026-02-28 10:40 ` Krzysztof Kozlowski [this message]
2026-03-13 10:20 ` Alexandre Belloni
-- strict thread matches above, loose matches on Subject: below --
2026-02-28 13:13 Piyush Patle
2026-02-28 13:26 ` Krzysztof Kozlowski
2026-02-20 7:48 [PATCH v2] " Krzysztof Kozlowski
2026-02-20 8:47 ` [PATCH v3] " Piyush Patle
2026-02-21 10:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228-classy-sexy-sponge-dba71b@quoll \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox