Re: [PATCH v3 4/6] dt-bindings: mfd: max77620: convert to DT schema

Svyatoslav Ryhel
2026-03-07T13:17:45Z

сб, 7 бер. 2026 р. о 14:46 Krzysztof Kozlowski <krzk@kernel.org> пише:
>
> On Fri, Mar 06, 2026 at 03:33:49PM +0200, Svyatoslav Ryhel wrote:
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/mfd/max77620.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pmic@3c {
> > + compatible = "maxim,max77620";
> > + reg = <0x3c>;
> > +
> > + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>
> This is odd interrupt. It's I2C device, so how can it be GIC?
>

I have used layout from Tegra device. I will switch to smth simpler.

> > + #interrupt-cells = <2>;
> > + interrupt-controller;
> > +
> > + #gpio-cells = <2>;
> > + gpio-controller;
> > +
> > + #thermal-sensor-cells = <0>;
> > +
> > + system-power-controller;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&max77620_default>;
> > +
> > + max77620_default: pinmux {
> > + gpio0 {
> > + pins = "gpio0";
> > + function = "gpio";
> > + };
> > +
> > + gpio1 {
> > + pins = "gpio1";
> > + function = "fps-out";
> > + maxim,active-fps-source = <MAX77620_FPS_SRC_0>;
> > + };
>
> Messed indentation.
>

Acknowledged.

> > +
> > + gpio2 {
> > + pins = "gpio2";
> > + function = "fps-out";
> > + maxim,active-fps-source = <MAX77620_FPS_SRC_1>;
> > + };
> > +
> > + gpio3 {
> > + pins = "gpio3";
> > + function = "gpio";
> > + };
> > +
> > + gpio4 {
> > + pins = "gpio4";
> > + function = "32k-out1";
> > + };
> > +
> > + gpio5_6 {
>
> No underscoers in node names. Use hyphen.
>

Acknowledged.

> > + pins = "gpio5", "gpio6";
> > + function = "gpio";
> > + drive-push-pull = <1>;
> > + };
> > +
> > + gpio7 {
> > + pins = "gpio7";
> > + function = "gpio";
> > + };
> > + };
>
> Best regards,
> Krzysztof
>