From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: cmos: Remove redundant include of linux/acpi.h
Date: Sat, 4 Apr 2026 12:19:45 +0200 [thread overview]
Message-ID: <20260404101945603a5e04@mail.local> (raw)
In-Reply-To: <177523251878.1559844.5790356423146303538.b4-ty@b4>
On 03/04/2026 18:08:50+0200, Alexandre Belloni wrote:
> On Wed, 04 Mar 2026 10:35:33 +0800, Chen Ni wrote:
> > The header file <linux/acpi.h> is already included globally at the top
> > of the file. The second inclusion inside the #ifdef CONFIG_ACPI block is
> > redundant because the header uses include guards to prevent multiple
> > inclusions.
> >
> > Remove the duplicate line to clean up the code and slightly reduce
> > preprocessing overhead.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] rtc: cmos: Remove redundant include of linux/acpi.h
> https://git.kernel.org/abelloni/c/a33bf4b6adf7
>
I'm dropping this as AI seemed to agree with you but acpi.h has actually
never been included twice in this file.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-04-04 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 2:35 [PATCH] rtc: cmos: Remove redundant include of linux/acpi.h Chen Ni
2026-04-03 16:08 ` Alexandre Belloni
2026-04-04 10:19 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260404101945603a5e04@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox