[PATCH] rtc: cmos: Remove redundant include of linux/acpi.h

[PATCH] rtc: cmos: Remove redundant include of linux/acpi.h

[Chen Ni]

The header file <linux/acpi.h> is already included globally at the top
of the file. The second inclusion inside the #ifdef CONFIG_ACPI block is
redundant because the header uses include guards to prevent multiple
inclusions.

Remove the duplicate line to clean up the code and slightly reduce
preprocessing overhead.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/rtc/rtc-cmos.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index 9ac5bab846c1..7c06b9d19273 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -743,8 +743,6 @@ static irqreturn_t cmos_interrupt(int irq, void *p)
 
 #ifdef	CONFIG_ACPI
 
-#include <linux/acpi.h>
-
 static u32 rtc_handler(void *context)
 {
 	struct device *dev = context;
-- 
2.25.1

Re: [PATCH] rtc: cmos: Remove redundant include of linux/acpi.h

[Alexandre Belloni]

On Wed, 04 Mar 2026 10:35:33 +0800, Chen Ni wrote:
> The header file <linux/acpi.h> is already included globally at the top
> of the file. The second inclusion inside the #ifdef CONFIG_ACPI block is
> redundant because the header uses include guards to prevent multiple
> inclusions.
> 
> Remove the duplicate line to clean up the code and slightly reduce
> preprocessing overhead.
> 
> [...]

Applied, thanks!

[1/1] rtc: cmos: Remove redundant include of linux/acpi.h
      https://git.kernel.org/abelloni/c/a33bf4b6adf7

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] rtc: cmos: Remove redundant include of linux/acpi.h

[Alexandre Belloni]

On 03/04/2026 18:08:50+0200, Alexandre Belloni wrote:
> On Wed, 04 Mar 2026 10:35:33 +0800, Chen Ni wrote:
> > The header file <linux/acpi.h> is already included globally at the top
> > of the file. The second inclusion inside the #ifdef CONFIG_ACPI block is
> > redundant because the header uses include guards to prevent multiple
> > inclusions.
> > 
> > Remove the duplicate line to clean up the code and slightly reduce
> > preprocessing overhead.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] rtc: cmos: Remove redundant include of linux/acpi.h
>       https://git.kernel.org/abelloni/c/a33bf4b6adf7
> 

I'm dropping this as AI seemed to agree with you but acpi.h has actually
never been included twice in this file.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com