From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9A92580F2; Sun, 19 Apr 2026 13:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776604750; cv=none; b=mkAU2VugrQlNxpd3/v6Ilcsg9qtnKw5eArflZw5LcR/0whEXaiTUaS+/eZWJWm1cq6eAa2Nr2L1WHpfrRVhNhClv8MvqtdtxBp+0KV+QzoKgDXcC5EMVY8Ran0+vDBqKuBa7Z2mjs4BmFz7LFxWZVLjyByfmIzojhfIWhFgGBSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776604750; c=relaxed/simple; bh=AvLVvkGMx5KNZbNVEJf7B+DrKxVga6LUIBz3jALnThw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=E/3fPuMCXwAJ8HguKGMu36C+LeagGxcPMHbGZBQNB+hqk95kWYzB4/gh4fYc7ursGnbGT9TdD/fNRhc3Q8a7mdPkJDVYR5z9BTi122ucuAUIEirKIeMucLh/aBcOzlKKshAGleBADHskpHCwjRQD/me/mrONuZkKnVApPzP3PPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dzlJqSQ0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dzlJqSQ0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A533EC2BCAF; Sun, 19 Apr 2026 13:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776604750; bh=AvLVvkGMx5KNZbNVEJf7B+DrKxVga6LUIBz3jALnThw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dzlJqSQ08YUJ03UQYUUa4fEA/Tc9oM4uFmVjqf9VoH4oXrUMBIG2h7I33q6bSbTKo 1XHc9p/U675xQntON8jfbD0tr7Y4SdqJi+Sg2sKf00RyWFbhmtQROiyKxDxilZEGxM xndvM+MS70K4sO51ukS52IWkQmsH9QwPB3sxWS05tBXEbzrooMRhXylneIGqfwNFMU NWN5DykZONDBOGw3axSIbr5IlBHRW01sh95v4LPImFtUd7wsHBH6jkNbWEVfBP1lGa t0aoJnSsz0WPb6AHBeXLcvbEHKVh1M9icSF+ubZEcK4pYEx9RuRvRVgOptO9ohjugQ 518ZGkSyqGs0g== Date: Sun, 19 Apr 2026 14:18:53 +0100 From: Jonathan Cameron To: Yury Norov Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 3/9] iio: intel_dc_ti_adc: switch to using FIELD_GET_SIGNED() Message-ID: <20260419141853.586ae273@jic23-huawei> In-Reply-To: <20260417173621.368914-4-ynorov@nvidia.com> References: <20260417173621.368914-1-ynorov@nvidia.com> <20260417173621.368914-4-ynorov@nvidia.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 17 Apr 2026 13:36:14 -0400 Yury Norov wrote: > Switch from sign_extend32(FIELD_GET()) to the dedicated > FIELD_GET_SIGNED() and don't provide the fields length explicitly. > > Signed-off-by: Yury Norov Assuming any remaining discussion on the implementation of the macro shakes out, this looks like a good little cleanup to me. Not sure how you want to merge this but if it's going through another tree. Acked-by: Jonathan Cameron > --- > drivers/iio/adc/intel_dc_ti_adc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/intel_dc_ti_adc.c b/drivers/iio/adc/intel_dc_ti_adc.c > index 0fe34f1c338e..b5afad713e2d 100644 > --- a/drivers/iio/adc/intel_dc_ti_adc.c > +++ b/drivers/iio/adc/intel_dc_ti_adc.c > @@ -290,8 +290,8 @@ static int dc_ti_adc_probe(struct platform_device *pdev) > if (ret) > return ret; > > - info->vbat_zse = sign_extend32(FIELD_GET(DC_TI_VBAT_ZSE, val), 3); > - info->vbat_ge = sign_extend32(FIELD_GET(DC_TI_VBAT_GE, val), 3); > + info->vbat_zse = FIELD_GET_SIGNED(DC_TI_VBAT_ZSE, val); > + info->vbat_ge = FIELD_GET_SIGNED(DC_TI_VBAT_GE, val); > > dev_dbg(dev, "vbat-zse %d vbat-ge %d\n", info->vbat_zse, info->vbat_ge); >