From: Balakrishnan Sambath <balakrishnan.s@microchip.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
"Orson Zhai" <orsonzhai@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-rtc@vger.kernel.org>,
"Balakrishnan Sambath" <balakrishnan.s@microchip.com>
Subject: [PATCH 2/4] rtc: moxart: convert to dev_err_probe()
Date: Thu, 28 May 2026 09:16:45 +0530 [thread overview]
Message-ID: <20260528-cleanup-dev-err-probe-rtc-v1-2-29dc9cb6c3f0@microchip.com> (raw)
In-Reply-To: <20260528-cleanup-dev-err-probe-rtc-v1-0-29dc9cb6c3f0@microchip.com>
Use dev_err_probe() in place of dev_err() and return, which
communicates the error type and helps debugging hardware issues.
No functional change.
Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
---
drivers/rtc/rtc-moxart.c | 25 +++++++++----------------
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/rtc/rtc-moxart.c b/drivers/rtc/rtc-moxart.c
index 2247dd39ee4..e1766f03d73 100644
--- a/drivers/rtc/rtc-moxart.c
+++ b/drivers/rtc/rtc-moxart.c
@@ -253,26 +253,20 @@ static int moxart_rtc_probe(struct platform_device *pdev)
moxart_rtc->gpio_data = devm_gpiod_get(&pdev->dev, "rtc-data",
GPIOD_IN);
ret = PTR_ERR_OR_ZERO(moxart_rtc->gpio_data);
- if (ret) {
- dev_err(&pdev->dev, "can't get rtc data gpio: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "can't get rtc data gpio\n");
moxart_rtc->gpio_sclk = devm_gpiod_get(&pdev->dev, "rtc-sclk",
GPIOD_ASIS);
ret = PTR_ERR_OR_ZERO(moxart_rtc->gpio_sclk);
- if (ret) {
- dev_err(&pdev->dev, "can't get rtc sclk gpio: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "can't get rtc sclk gpio\n");
moxart_rtc->gpio_reset = devm_gpiod_get(&pdev->dev, "rtc-reset",
GPIOD_ASIS);
ret = PTR_ERR_OR_ZERO(moxart_rtc->gpio_reset);
- if (ret) {
- dev_err(&pdev->dev, "can't get rtc reset gpio: %d\n", ret);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "can't get rtc reset gpio\n");
spin_lock_init(&moxart_rtc->rtc_lock);
platform_set_drvdata(pdev, moxart_rtc);
@@ -280,10 +274,9 @@ static int moxart_rtc_probe(struct platform_device *pdev)
moxart_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
&moxart_rtc_ops,
THIS_MODULE);
- if (IS_ERR(moxart_rtc->rtc)) {
- dev_err(&pdev->dev, "devm_rtc_device_register failed\n");
- return PTR_ERR(moxart_rtc->rtc);
- }
+ if (IS_ERR(moxart_rtc->rtc))
+ return dev_err_probe(&pdev->dev, PTR_ERR(moxart_rtc->rtc),
+ "devm_rtc_device_register failed\n");
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2026-05-28 3:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 3:46 [PATCH 0/4] rtc: convert several drivers to dev_err_probe() Balakrishnan Sambath
2026-05-28 3:46 ` [PATCH 1/4] rtc: palmas: convert " Balakrishnan Sambath
2026-06-30 17:10 ` Alexandre Mergnat
2026-05-28 3:46 ` Balakrishnan Sambath [this message]
2026-06-30 17:10 ` [PATCH 2/4] rtc: moxart: " Alexandre Mergnat
2026-05-28 3:46 ` [PATCH 3/4] rtc: sc27xx: " Balakrishnan Sambath
2026-06-30 17:10 ` Alexandre Mergnat
2026-05-28 3:46 ` [PATCH 4/4] rtc: s35390a: " Balakrishnan Sambath
2026-06-30 17:10 ` Alexandre Mergnat
2026-07-01 7:26 ` Balakrishnan.S
2026-07-01 8:57 ` Alexandre Belloni
2026-07-02 4:01 ` Balakrishnan.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528-cleanup-dev-err-probe-rtc-v1-2-29dc9cb6c3f0@microchip.com \
--to=balakrishnan.s@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox