From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0E6686341 for ; Wed, 15 Jul 2026 02:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784081978; cv=none; b=deYdL6g9Z2By6qnqvPVpHsVR80+ovKH4+k8WEKrRygMFHK0LO1i8crCp2tLVwzXWUM9H01FJBktsBiVe0W2SXnkdHtf6UnnO25PX0dXhqRNci2eVgvnE/5W202Mb+zF97z3MZgdgb9qP23Dyuv+8KSiTL3YxuVljkLQYQc0+l8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784081978; c=relaxed/simple; bh=9hNvJLwHoOEou8LLYeKhtdn5GPgGf0qbTrk5z2xNAq0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OQyKN/JyLEJ5i0STonDq5cFaolTlDnEx0V0ag3IS2w8ohtlcnPEII8i3tIsTnx2itJqDAgGBI7jRQ1aKyBx0iuwBWRTcm/YyBh5Mc3nmJVV+qTLmmQDCK73aV2W33TepFlsfpqrWC6RFhdPWhqTo6pW5wsn/66PBaPgAaasYkaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sl4sF5uA; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sl4sF5uA" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cae1a3a744so36312265ad.3 for ; Tue, 14 Jul 2026 19:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784081976; x=1784686776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3+A/CsOvZ5kwNPw68MEUIBx9OhApXOPeGcI1WPKSM0g=; b=sl4sF5uALUtSIQeKm52rsSwsCMcxl6TVWslB5xdwtMYw73CTiXFfE4uZJAtAvKuzAL 4L5TwCJE5D/JAqks0MyrHQk23056tEUjKxAu6f5fYtuDHdk8sgi/Mu0YRe99xBpnr102 +RK8Rf0p6Opz9fpvQK0s1u9m862jaz1A97liPOdkzNESRXn87VH9DhjanwDpfCa95E+N W74xAv9F83WYlySInF+aIcKujY6TL8J/L7OWdJjDl6T1SI2gHPto9JBr4glP6CAJTWrx s5Wq6BlFNzBo8EPfQpSo+A6o8YqhA6BS615cvsmRhrvUaXY2RQGB0hnc9dBc35/6LZ4A fZ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784081976; x=1784686776; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3+A/CsOvZ5kwNPw68MEUIBx9OhApXOPeGcI1WPKSM0g=; b=HR8ViX/7uy9ud6KIzflIjIJqA3bM+e+JInzk4xRZI3GMoBVu381Bhf3KMlCFieuRNY 9bLow/8EtncF/euPyW74XVaM4EnGpVxuVHSP+KSXTET7ZWYsxQ7o6TL1YvJGd2cB/t9Z UGhJQPzLK8kBauKp3VLSy56ARaplSfutNIPvXghtXvkCcmXkqABwZKO7MEkBS5Wrca5R RKH0WrNccnLQAy8/I2Bj95omRGvOyBALPhHFVd5SV7eOqJ4s+B8i0mEgDTZqWoWprQ6O UsVTvjLdZaXDQtPwd8V1qZY9kZOR9feflxZwqMmpYOn144mJpcOxzvGpWycosVB1VXXq PBgQ== X-Gm-Message-State: AOJu0Yyzo6tG3+7eFX57c+K4jfuVdoSZUJ9C97C9WUQCtQPZJKqBYOEV IGLfJHzbnrDfvd5X5jf1LMyjerKPhA7GIGVW1RB1OrVPp4FuMMiPVYa68FgjxZAq X-Gm-Gg: AfdE7ckQnAZpQsBuEeAvBc28aDdHJaXOWBNeoFtLGh03W+VHztzjbQlXQQTv3LrrcyF E6DjS/IUdKbYHoHLg7axXe4O0N9NZbYj6ShGKUjYsr1XtQNvz4IvQWnswMa4GjKZ6POwVV1w9ud wjJ15DMpC54VMGRYDlzIt/wZNDY0VQiDjEC5RwSCYCWzUm5YwoMrcKztXJKs/YAMQHW9dtn4MgC oAtFlKPYAqp62IWA5AfmRZzfQIT5otnAJVeeQsSUA+52+rTMiJtVwIUKhlUT0XOZ6a/pXU3NpGK 5G0HC0zyh1hY37rPeRc8F6tHBgWXJM1D0kGdIrkWyuHcVd0BajoqWJReH4OJU1rOf20GeA9MynN TaY/G3DdWIsfpVZM53qEI2WR6dy/soxJ8Klyf/bi0015rEmT8aCh0HNbiCmYeAqBrPPkqdtrhDL ndwrinxpGrXsyA/qOe1bPgSSb9ipjVdIxBqGfXcsVkbFVvbJQiEXs/f52pTpjO92X8MXRqC/B/G 2umscaqQ0cGb91G32JHZY0DwRX2iivzhTyU8uU/9+CO4Mj7M+b/mR0fV48p+Ox+3A== X-Received: by 2002:a05:6a20:3d92:b0:3c0:9c1a:893e with SMTP id adf61e73a8af0-3c34d8c599fmr6957139637.70.1784081976192; Tue, 14 Jul 2026 19:19:36 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca7f626fb78sm8653754a12.13.2026.07.14.19.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 19:19:35 -0700 (PDT) From: Rosen Penev To: linux-rtc@vger.kernel.org Cc: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] rtc: stmp3xxx: use devm_platform_ioremap_resource() Date: Tue, 14 Jul 2026 19:19:33 -0700 Message-ID: <20260715021933.1551663-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the open-coded platform_get_resource() plus devm_ioremap() sequence with a single devm_platform_ioremap_resource() call, which folds the resource lookup and mapping into one step and returns an ERR_PTR on failure, checked with IS_ERR() and propagated via PTR_ERR(). Move the mapping ahead of the devm_kzalloc() so that an error or deferred probe is handled before the rtc_data allocation, avoiding needless work. The fsl,stmp3xxx-rtc nodes in imx23.dtsi (reg = <0x8005c000 0x2000>) and imx28.dtsi (reg = <0x80056000 0x2000>) each provide a single non-overlapping IORESOURCE_MEM window, so the region reservation now performed by devm_platform_ioremap_resource() introduces no conflict. Built for ARM (mxs_defconfig + CONFIG_RTC_DRV_STMP) with LLVM=1; drivers/rtc/rtc-stmp3xxx.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/rtc/rtc-stmp3xxx.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c index 7afcd14aeee5..05f128ccf827 100644 --- a/drivers/rtc/rtc-stmp3xxx.c +++ b/drivers/rtc/rtc-stmp3xxx.c @@ -245,28 +245,21 @@ static void stmp3xxx_rtc_remove(struct platform_device *pdev) static int stmp3xxx_rtc_probe(struct platform_device *pdev) { struct stmp3xxx_rtc_data *rtc_data; - struct resource *r; + void __iomem *io; u32 rtc_stat; u32 pers0_set, pers0_clr; u32 crystalfreq = 0; int err; + io = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(io)) + return PTR_ERR(io); + rtc_data = devm_kzalloc(&pdev->dev, sizeof(*rtc_data), GFP_KERNEL); if (!rtc_data) return -ENOMEM; - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) { - dev_err(&pdev->dev, "failed to get resource\n"); - return -ENXIO; - } - - rtc_data->io = devm_ioremap(&pdev->dev, r->start, resource_size(r)); - if (!rtc_data->io) { - dev_err(&pdev->dev, "ioremap failed\n"); - return -EIO; - } - + rtc_data->io = io; rtc_data->irq_alarm = platform_get_irq(pdev, 0); rtc_stat = readl(rtc_data->io + STMP3XXX_RTC_STAT); -- 2.55.0