From: sashiko-bot@kernel.org
To: "Linkai Gong" <gonglinkai@kylinos.cn>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: gamecube: check return value of devm_rtc_register_device()
Date: Fri, 31 Jul 2026 08:06:44 +0000 [thread overview]
Message-ID: <20260731080644.953911F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260731080239.383831-1-gonglinkai@kylinos.cn>
> gamecube_rtc_probe() ignored the return value of
> devm_rtc_register_device() and always returned success. Propagate the
> error so probe fails when RTC registration fails.
>
> Fixes: 86559400b3ef ("rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U")
> Signed-off-by: Linkai Gong <gonglinkai@kylinos.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260731080239.383831-1-gonglinkai@kylinos.cn?part=1
next prev parent reply other threads:[~2026-07-31 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 8:02 [PATCH] rtc: gamecube: check return value of devm_rtc_register_device() Linkai Gong
2026-07-31 8:06 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-31 8:02 Linkai Gong
2026-07-31 8:06 ` sashiko-bot
2026-07-31 8:04 Linkai Gong
2026-07-31 8:08 ` sashiko-bot
2026-08-20 21:28 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731080644.953911F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=gonglinkai@kylinos.cn \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox