From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7541C47D466 for ; Fri, 31 Jul 2026 18:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785523812; cv=none; b=PiqXR5xXF3yfyedKIF/0RdjI9fJwNX6CefwVxx31VGwOsnx/HKozz7Au0UF3btSInywPE+Ncfxs6BsPSg16IkLhy30+mEb56ihD0F123n1RPoDcKvzK+uYfDiY6sY1uIODB3W8323zPzZjIhIODG45Rd75u4DUGZZl33NXWoFOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785523812; c=relaxed/simple; bh=8Fp1cIgdmX68QdFeBMdb2nap5ZPDtbuhyKtuCyvwSGY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P9bJ9ItKJeMOuR+lA2/vNvMMEZy3jHwGF4CCI89TK4iHT5vddeGLTlK5X6hB5J+pF+/BrVTAJlyfB6cr+jTFvC7EKymFy/3MUZ1WKp6gNZmbFkb/a46vSdVOBIySvMOpg03qKdZpKrpSPWDuWYr4k311j2Hd453kuJgU5FaiRtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ovVT9+/d; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ovVT9+/d" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-4758bd3731bso1416289f8f.0 for ; Fri, 31 Jul 2026 11:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785523810; x=1786128610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kqCqqXB73tbV7DKWXe+e3HNB8ml/FvB4UJsSADni1XE=; b=ovVT9+/dSbRExsh/rDc3IxJAh6H4jL1vh+5M9DUlMEK5buO9u2sprvhrgI5+/8YYR0 WhDlq0dalcVkbgQ8mP9Lr3iAm9pjWic/AMNf7QGqcifi9dsE6z1LCva3ecL3H3PBbn6y 4jkwScmW5P7qzuFM7x4Qlb3CX+1D3KKtYzqvwt34xgqwBr8O3TGlaOUfRAHXcN3GfupY 6DNFdnMKzgJVZ1DG0fKbih/5UnvDFj3W7YAC8z5a666vaw5bLhz3EPYCd9RLhl4r9n5j T/IWp9FMH4YKTqNJOTIdB+zICkgD8dmNLy0jPFSWgc3TupGN3WQodOUI/8dhq0aS7smg q/zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785523810; x=1786128610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kqCqqXB73tbV7DKWXe+e3HNB8ml/FvB4UJsSADni1XE=; b=lo57bkw+BtndKF/zYQQD4yQisO1jTQ7FtScJdA8QuaMVZwpoMguBte0Xl/A7xBM7zj 8rHASnpDdc2K4M6VgN2B7CpasiUm1KQNwCei+3CSgsESzkchSY3TPDhYB5fkMEGuzTeC 8wk61pzYejILD/0oAwBTYdRUKdzNIdz4XMjwprt5Z40w6BR71SwCQr/ZSnmh3CqWK+oa PXpedBJDkG0OGpuGcq8M0LccTEkHkPnchnXkG4gwJQh6qKaQ+j1edR/eshXMDpg1NxLF TlLIcYamDmCiF9yfT+W8GjAiZx5YLwQLOlzuUkay1vdHA7hW2NQ6xrnH3DEjs7AwLx9E nttw== X-Gm-Message-State: AOJu0YwbD3iOwRpue4rzq0JDzrs4mCeyCk+aUEc8UdOr4hQm/Nj2zCzZ lyppKnEi+CLEK6eFHgRvIgl2PO2jvinapgYc84Z61rIf7WWphZ/JhDJF X-Gm-Gg: AR+sD138gxrVN4vctEBLCoCGdrQWytL+LX57Bv8F6Bq7zHg33g/eytYjqdE+4poxw+w 2v9mhr/FwevdR1NsNLbEQwK7xli/zUns/lYhLpzu1zHQ9XLJMqwyAPQWn5P8LcbIdqdtscWPGvy 3JJnde9bXejhmhbKCjKMLRPn5JGdc9O0HjHy3RHqnk6nUEJLe27RG4XBoGvK9OJygG15eV0YmaV juuf0IZ3vkHAXJEGLKJUvsWfH87VWP6NXZ5d7l9YoJ4rM7ZliafsSD5tmHyjQMqATKjOuZ5BstF syLKF7Zz7e3o0x41NHrGvN/3xPezEME+Lg7q2k+CYS5VGsNxhgoJy0rJPqJ5KGcKpmdxFaWlVET Bs7XBzHesBxDM6okNfewijxgwC8Gh/MUcKIKijR1Yh/te+8F4n2Qs2emCZjFFwGNz1fbDJN1aYm APORyOxYGmTKLV6AmUW//5DPLoPx62ctXXszgwdEYS9FTRRsBik8f5+QFUQxviCl33 X-Received: by 2002:a05:6000:2489:b0:47f:537b:d5d0 with SMTP id ffacd0b85a97d-47fd72a8070mr1564677f8f.28.1785523809624; Fri, 31 Jul 2026 11:50:09 -0700 (PDT) Received: from antoniarch ([78.211.133.142]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd42d91b3sm8741488f8f.14.2026.07.31.11.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 11:50:09 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v3 4/8] rtc: abx80x: add irq to struct abx80x_priv Date: Fri, 31 Jul 2026 20:48:27 +0200 Message-ID: <20260731184831.44037-5-apokusinski01@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260731184831.44037-1-apokusinski01@gmail.com> References: <20260731184831.44037-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This way the irq number is not tied to the i2c_client and can be easily accessed also in the case of ABX81X SPI clocks. Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-abx80x.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index b84fce0ef294..4ac3ace687a1 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -129,6 +129,7 @@ struct abx80x_priv { struct i2c_client *client; struct watchdog_device wdog; struct mutex lock; + int irq; }; static int abx80x_write_config_key(struct i2c_client *client, u8 key) @@ -299,11 +300,12 @@ static irqreturn_t abx80x_handle_irq(int irq, void *dev_id) static int abx80x_read_alarm(struct device *dev, struct rtc_wkalrm *t) { struct i2c_client *client = to_i2c_client(dev); + struct abx80x_priv *priv = i2c_get_clientdata(client); unsigned char buf[7]; int irq_mask, err; - if (client->irq <= 0) + if (priv->irq <= 0) return -EINVAL; err = i2c_smbus_read_i2c_block_data(client, ABX8XX_REG_ASC, @@ -335,7 +337,7 @@ static int abx80x_set_alarm(struct device *dev, struct rtc_wkalrm *t) u8 alarm[6]; int err; - if (client->irq <= 0) + if (priv->irq <= 0) return -EINVAL; alarm[0] = 0x0; @@ -941,6 +943,7 @@ static int abx80x_probe(struct i2c_client *client) priv->rtc->ops = &abx80x_rtc_ops; priv->client = client; + priv->irq = client->irq; err = devm_mutex_init(&client->dev, &priv->lock); if (err) return err; @@ -957,19 +960,19 @@ static int abx80x_probe(struct i2c_client *client) if (err) return err; - if (client->irq > 0) { - dev_info(&client->dev, "IRQ %d supplied\n", client->irq); - err = devm_request_threaded_irq(&client->dev, client->irq, NULL, + if (priv->irq > 0) { + dev_info(&client->dev, "IRQ %d supplied\n", priv->irq); + err = devm_request_threaded_irq(&client->dev, priv->irq, NULL, abx80x_handle_irq, IRQF_SHARED | IRQF_ONESHOT, "abx8xx", client); if (err) { dev_err(&client->dev, "unable to request IRQ, alarms disabled\n"); - client->irq = 0; + priv->irq = 0; } } - if (client->irq <= 0) + if (priv->irq <= 0) clear_bit(RTC_FEATURE_ALARM, priv->rtc->features); err = rtc_add_group(priv->rtc, &rtc_calib_attr_group); -- 2.55.0