Re: [RESEND v7 1/2] dt-bindings: rtc: Add pcf85053 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The schema incorrectly uses `additionalProperties: false` instead of `unevaluatedProperties: false` while inheriting from `rtc.yaml#`, which improperly rejects standard RTC properties.
- [Low] The description for `nxp,interface` contains a typo ('ready only') that alters the meaning of the sentence.
--

--- Patch [1]: [RESEND v7 1/2] dt-bindings: rtc: Add pcf85053 support ---
commit c4402003b175003ee64d2fbdc100051ae1f80c64
Author: Lakshay Piplani <lakshay.piplani@nxp.com>

dt-bindings: rtc: Add pcf85053 support

This commit adds device tree bindings for the NXP PCF85053 RTC chip,
introducing a new schema file and defining properties like nxp,interface
and nxp,write-access.

> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml
[ ... ]
> +  nxp,interface:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [ primary, secondary ]
> +    description: |
[ ... ]
> +      The actual role depends on whether 'nxp,write-access' is also specified.
> +      Supported configurations are:-
> +        1. Primary with 'nxp,write-access' -> primary claims write ownership.
> +        2. Primary without 'nxp,write-access' -> primary is ready only; secondary may write.

[Severity: Low]
This isn't a bug, but is "ready only" a typo for "read only" in this
description?

> +        3. Secondary (must not specify 'nxp,write-access') -> Secondary writes only
> +           when no primary claims ownership.
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - nxp,interface
> +
> +additionalProperties: false
> +
> +allOf:
> +  - $ref: rtc.yaml#

[Severity: Medium]
Does using additionalProperties: false here incorrectly reject standard RTC
properties from rtc.yaml?

Since this schema includes an allOf reference to rtc.yaml, shouldn't this be
unevaluatedProperties: false so that properties like wakeup-source are
properly permitted during schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260812073552.3542956-1-lakshay.piplani@nxp.com?part=1