Re: [PATCH v6 1/6] dt-bindings: rtc: Add pinctrl for S35390A

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The binding adds a clock provider capability (`#clock-cells`) but fails to list it in the `required` properties and include it in the `examples` section.
- [Medium] The schema fails to enforce the documented constraint that the `pmin2` function can only be used with pin `int1`.
--

--- Patch [1]: [PATCH v6 1/6] dt-bindings: rtc: Add pinctrl for S35390A ---
commit ed4fe5fd689ace047dd6fd7d73cbfef4879078ec
Author: Markus Probst <markus.probst@posteo.de>

dt-bindings: rtc: Add pinctrl for S35390A

This commit moves the devicetree bindings for sii,s35390a into its own file.
It also adds properties to configure pins via pinctrl to allow the interrupt
signal 1 to be used for the wakeup alarm.

> diff --git a/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml

[ ... ]

> +          function:
> +            $ref: /schemas/types.yaml#/definitions/string
> +            description: |
> +              Pin function:
> +              - ignore:  Preserve the previous state.
> +              - disable: Disable pin output.
> +              - wakeup:  Output wakes up the system.
> +              - clock:   Output clock pulse.
> +              - pmin1:   Minute periodical output with 50% duty.
> +              - pmin2:   Minute periodical output L for 7.81 ms.
> +                         Can only be used with pin int1.
> +            enum:
> +              - ignore
> +              - disable
> +              - wakeup
> +              - clock
> +              - pmin1
> +              - pmin2

[Severity: Medium]
The documentation specifies that pmin2 can only be used with pin int1. Should
the schema include an allOf/if conditional block to logically enforce this
restriction, preventing pmin2 from being used with int2?

[ ... ]

> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Does #clock-cells need to be added to this list of required properties?

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        rtc@30 {
> +            compatible = "sii,s35390a";
> +            reg = <0x30>;
> +            pinctrl-0 = <&rtc_pins_default>;
> +            pinctrl-names = "default";
> +
> +            wakeup-parent = <&int>;

[Severity: Medium]
Should the examples section include the #clock-cells property to ensure it
passes validation checks?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-rtc_s35390a_int1-v6-0-df96569e3412@posteo.de?part=1