Re: [PATCH v8 1/6] dt-bindings: rtc: Add pinctrl for S35390A

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] DT binding schema strictly requires 2 items for `interrupt-names` even when only 1 interrupt is defined.
- [Medium] Incorrect use of `additionalProperties: false` alongside `$ref` breaks dt-schema validation and inheritance.
--

commit b7c0d2bd5acb5ccb26e8865062b4b49889e6cf5d
Author: Markus Probst <markus.probst@posteo.de>

dt-bindings: rtc: Add pinctrl for S35390A

This commit moves the devicetree bindings for the sii,s35390a RTC into
its own dedicated schema file. It also adds the necessary properties to
configure individual pins via pinctrl, allowing the interrupt signal to
be used for wakeup alarms.

> diff --git a/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml
> new file mode 100644
> index 0000000000000..dfe632c4b2c85
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml
[ ... ]
> +  interrupts:
> +    minItems: 1
> +    maxItems: 2
> +    description: Supports up to 2 interrupt lines via the INT1 and INT2 pins.
> +
> +  interrupt-names:
> +    items:
> +      - const: int1
> +      - const: int2

[Severity: Medium]
Since the interrupts property allows minItems: 1, does interrupt-names
also need minItems: 1?  Without it, the implicit minimum is exactly 2 items,
which will cause schema validation to fail for valid device trees that only
configure a single interrupt (e.g., INT1) and specify
interrupt-names = "int1";.

[ ... ]
> +patternProperties:
> +  "^pins":
> +    type: object
> +    additionalProperties: false
> +
> +    patternProperties:
> +      "-pins$":
> +        type: object
> +        additionalProperties: false
> +
> +        allOf:
> +          - $ref: /schemas/pinctrl/pinmux-node.yaml#

[Severity: Medium]
Should unevaluatedProperties: false be used here instead of
additionalProperties: false?  Using additionalProperties: false alongside a
$ref to another schema strictly rejects any properties not explicitly
listed in this block, which breaks the evaluation of inherited properties
from pinmux-node.yaml as well as generic dt-schema internal properties
like phandle or $nodename.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-rtc_s35390a_int1-v8-0-dac1dc86ce1f@posteo.de?part=1