Re: [PATCH v8 1/2] dt-bindings: rtc: Add pcf85053 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree binding defines `#clock-cells` but fails to include it in the `required` list and `examples` section, violating subsystem guidelines for provider capabilities.
--

commit b13d4a07a31d804f2eb400ecaefe4d209dc9b4ea
Author: Lakshay Piplani <lakshay.piplani@nxp.com>

dt-bindings: rtc: Add pcf85053 support

This commit introduces the device tree bindings for the NXP PCF85053 RTC
chip. It defines properties like multi-host interface roles and provides
examples for both single and dual-host configurations.

> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - nxp,pcf85053

[ ... ]

> +  "#clock-cells":
> +    const: 0
> +
> +  clock-output-names:
> +    maxItems: 1

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - nxp,interface

[Severity: Medium]
Since the binding defines #clock-cells for clock provider capabilities, should
it also be included in this required list?

If #clock-cells is omitted from the required list, incomplete device tree
nodes missing this property will silently pass schema validation. Dependent
subsystems could then fail at runtime when attempting to use the missing
functionality.

[ ... ]

> +examples:
> +  # Single host example.
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      rtc@6f {
> +        compatible = "nxp,pcf85053";
> +        reg = <0x6f>;

[Severity: Medium]
If #clock-cells is made required, will this example also need to be updated to
include #clock-cells = <0>; so that it passes dt_binding_check?

> +        nxp,interface = "primary";
> +        nxp,write-access;
> +        interrupt-parent = <&gpio2>;
> +        interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> +      };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907102134.394717-1-lakshay.piplani@nxp.com?part=1