From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA1A52D2A6 for ; Mon, 7 Sep 2026 20:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788813253; cv=none; b=LElpKKnoBoIdxf4frOezA6mYhKh54kSpUV8jlgzJfK2aGl2bm6OQLWLgB2aZqTRnYI3ECWBJu5pzPqsonSHYd3mwImHJaz1maHRshH3upbvfOqbKysybAnoy/TfJXemHPR1icB3QNdzCBP6PeLSaHLRg5PlB82Cgx5fgkZXTkiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788813253; c=relaxed/simple; bh=h/d4lg5ZYxoEb/eMlkOvsuPSaUhSgZ4AwspfCz0TKr0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BwcAkh6Rgdy1lmRqwiFp2D6l8mnOeVgV98G9Gr+niMHJSbrSdH2deltzmQPeWhzIZ9ZtXbKBeRheAfsRgTm3Hux0hqAl0VzQROQc2y5gAjK1y/fZMkAmTxDX6otSNTNp8OMmIJSIQ0z/jDsZrD8iiNc+JkpYdMW/x+gCd7JOJ88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pruSq4uD; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pruSq4uD" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47fe89fb333so2528965f8f.3 for ; Mon, 07 Sep 2026 13:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788813250; x=1789418050; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wT2cQFs+SDhHO7xry69vOp9pKFSTK+W30fCT/siNbCw=; b=pruSq4uDV2rEv6eLC8hugiWfl39SUns4y/BuMozfJszlljaglX/Taw0y9gfYYnq0Em 5wUxCfdUvCZksWI1Av3tNEXKNvSezSjbuIY+aWt8u8f8RwYxtGe7HblWydiWsQ0q65FH FatK3ppwObVKIHGCa7+vWEoT1d4tSKgUEy8WPMCDuZevxrDdRzf6EvObrR4Pb2EClgiu zL3ppTF5qWYlLzfOgAJwZzUIOPBijA4nNnB907gVuSzWh+lA65+IUK1FN49oGe0899xl 4+lZSbz5EYuJsossVGsI+MdrQhEeLLHApZl1SQO+oPMmRpOczynb3bcqxhQAzSJCQ8zb tHXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788813250; x=1789418050; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wT2cQFs+SDhHO7xry69vOp9pKFSTK+W30fCT/siNbCw=; b=Piqj0AaykZ2rLdJyd0I/4S9Ane0l/iDYEKx7Iyebf4APwy86o6EUkTgBFZiKsOlkKp bbHUhnk/SjnWizjHvBYKK7C65zr6vgzPkYzZXPvyXO4HRIxbxiHdUpzxqMKAeY6I3Ne3 6MIUvZzhYucv36RAzTsHf504OeUCCNj6m/VOgVJjAaKY4wboaPHmUMvgi2lWMlCjBFFz 3Cz9jS0mOLfzxS/qhGTnfnE6B2B1ozOrFnc8HAsqoVBqneXjD4zFaNpuz2RdNGJGCaiT 71Oq5FBFWuQFnVhNX4lRK3T71VtfB5ujX2TzMkWCrOOOdcDUtkjjqvJZ5fDKqC85RB5g mL1A== X-Gm-Message-State: AFuF++nmxgPPdmxMqFsva6XhnfrPpzH/nntd3YvBlRWW3x4ZYH+GR82W t4i1faKo1ujANotH82sdDa3cmyQNplfNikpbnOmGKUhLdmzfdZIOp4Ml X-Gm-Gg: AYBFou3dt3+j/1+rUEo6G2hq7jDFrOj3eea2LNBE1oYRaLOh12D4LPzkvRtxZ4frTuU vQoo+hzQXw0HH9Es25pW4fpH6f9lTZeiomZl/yD4mkEpN5k4Ri+VgaZWGvk6iG4UDVL03Z5TQ0c ACnzEoljVMrX18ZU/zO/nFHcBIhM7ne5leSTGYnzhIHjvfOGAO26cXfqfwK3cSRyIYGC1jdY7WN M4vBOCRl7llkH5FCbEJbEfGhn2xFdl3lGfvQeIn3xhO9cJBAhHHjZBLCkyKOiwhSBcO84cgQy7K zfcpxGgWm+Fc7eK9XCg81YanMH8av5+odQ5DpfjWnXsjlzWFxvmFQuzKAGQTj8VLWjSTZYed1ow kSW/TtQXUiHonT8ecPKtEexhZni1+k8ddxMqAt51lIVfv8aIueubsdX9UpwPTyzcgZAYUy1h9AG OMTEb7QxR8hkczKuoOpZj0k+rfEixIGO65vfVOvZlgqHvFPlKOjJ3ZNL/jBl3qbA== X-Received: by 2002:a05:6000:4010:b0:485:96e3:3ede with SMTP id ffacd0b85a97d-48596e33fe0mr10881483f8f.14.1788813249786; Mon, 07 Sep 2026 13:34:09 -0700 (PDT) Received: from antoniarch ([78.212.37.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4858e239862sm25959116f8f.9.2026.09.07.13.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:34:09 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v6 5/9] rtc: abx80x: add irq to struct abx80x_priv Date: Mon, 7 Sep 2026 22:32:12 +0200 Message-ID: <20260907203216.53192-6-apokusinski01@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260907203216.53192-1-apokusinski01@gmail.com> References: <20260907203216.53192-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This way the irq number is not tied to the i2c_client and can be easily accessed also in the case of ABX81X SPI clocks. Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-abx80x.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index 8f9211bfb7e2..529f63e024f8 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -135,6 +135,7 @@ struct abx80x_priv { struct i2c_client *client; struct watchdog_device wdog; struct mutex lock; + int irq; }; static int abx80x_write_config_key(struct i2c_client *client, u8 key) @@ -305,11 +306,12 @@ static irqreturn_t abx80x_handle_irq(int irq, void *dev_id) static int abx80x_read_alarm(struct device *dev, struct rtc_wkalrm *t) { struct i2c_client *client = to_i2c_client(dev); + struct abx80x_priv *priv = i2c_get_clientdata(client); unsigned char buf[7]; int irq_mask, err; - if (client->irq <= 0) + if (priv->irq <= 0) return -EINVAL; err = i2c_smbus_read_i2c_block_data(client, ABX8XX_REG_ASC, @@ -343,7 +345,7 @@ static int abx80x_set_alarm(struct device *dev, struct rtc_wkalrm *t) u8 alarm[6]; int err; - if (client->irq <= 0) + if (priv->irq <= 0) return -EINVAL; alarm[0] = 0x0; @@ -949,6 +951,7 @@ static int abx80x_probe(struct i2c_client *client) priv->rtc->ops = &abx80x_rtc_ops; priv->client = client; + priv->irq = client->irq; err = devm_mutex_init(&client->dev, &priv->lock); if (err) return err; @@ -1000,19 +1003,19 @@ static int abx80x_probe(struct i2c_client *client) return -EIO; } - if (client->irq > 0) { - dev_info(&client->dev, "IRQ %d supplied\n", client->irq); - err = devm_request_threaded_irq(&client->dev, client->irq, NULL, + if (priv->irq > 0) { + dev_info(&client->dev, "IRQ %d supplied\n", priv->irq); + err = devm_request_threaded_irq(&client->dev, priv->irq, NULL, abx80x_handle_irq, IRQF_SHARED | IRQF_ONESHOT, "abx8xx", client); if (err) { dev_err(&client->dev, "unable to request IRQ, alarms disabled\n"); - client->irq = 0; + priv->irq = 0; } } - if (client->irq <= 0) + if (priv->irq <= 0) clear_bit(RTC_FEATURE_ALARM, priv->rtc->features); err = rtc_add_group(priv->rtc, &rtc_calib_attr_group); -- 2.55.0