From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 408A42F0C7E for ; Thu, 10 Sep 2026 03:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789012106; cv=none; b=F2MrU+Wy6IPGhTR8aAfhlGKehNyiJKsDIH6x87wmsTRDD4gfGVWT3bMNRW1oLCxZmRKjOJzXlo2v1ZWcjfsRY2GHzaNjYlo4w1+N805A0/BXfQAx3sHc7CfE9q8cnLOpQGczcAJ/qxWm5AMNOTzrICKp2WNTn2BL5MtXzankmMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789012106; c=relaxed/simple; bh=rsFI+sdwDURBfYcTPzPK+SDtUqdP4949pxLEKIwiRnk=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=dv/dy1qv+QSFSMZ8qO4L82qbIjiveD36SdyDs69aLZ7JtR7n1RyI08fnz4R313Re9LYXoUbZR4bvY83+rSsE1GfCPAbnZdjND226wkyfDcUi9TBVmi5AA5QQUm61Emzrf3S/6wkc0nQdSNEcChUxKnKaHuOiOV4kc7/Pjy1E5YU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wakel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XqI7s4t3; arc=none smtp.client-ip=209.85.215.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wakel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XqI7s4t3" Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb11535e6a1so7017206a12.0 for ; Wed, 09 Sep 2026 20:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789012104; x=1789616904; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zzi//Qm9WAlH1nWPVbEFeyj5g7F/Gg5oP3YDkfmtrmw=; b=XqI7s4t3INGeluRl81D6LJ7LqJixma1+QVvIm9+U4VqoQE+JWklQSTTW6K+CCJWBNX nZ2TSW1O6aHr/fNTtYCZ9GlqSp2LGlkGVI+DN8fxHGUp5VSiHqTfSjr58hbB/kb3OjhD sVhqes8bc3J1WKoI8ppRjt11YWnKtQXow2HJ7fsayz4tbC7P9/oZFcMu7rjZMC/Si1lN PmWfIpxlYpxL78y4H5zqAH2/cQhZFoTUvLhm7fPKqRP2oOxr4075OTvd9uvjzOi2iHVg 2NWF6jRgPxQPrRkPXPEryZo+wO/JIFB86tW10YkK+kQn+feMIGMtzAqVhJtViIFdNoUF qAJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789012104; x=1789616904; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zzi//Qm9WAlH1nWPVbEFeyj5g7F/Gg5oP3YDkfmtrmw=; b=b/0F5bB2X6MoqtSegf7JxQJ65oz8RAmu5EnNp4FLAvy4kOGcxc+hgzAJUeI1PtTImK BR//KB0qQaVUeDyPVYvjJc/ilqL3aykr6QMcVk3rLKAZXcdgWZqDqiT6MD9UVZHLNMq9 noLj52vi88Pr7xElUnqkgL3eUgUdahUEwTvlREv7abMhJTeBaxLEz1VWfh9CbPM/YepN n2xJ1AC+rxqVr0XnWhm+jq0ENajvd777BfTkAaPVHEL3CkkhvG9SAmdT3g/I5SKTFLpm LNT89TENcRiSDTX9kfW2ELGjxf0iVeRzS/nSleDvv5lqwnPM/XFvrQxr4zbFQV0MHvcq q3iw== X-Gm-Message-State: AFuF++n5awREWxh6pMlgNLgRr91RaE6fTkCfG75VI3mWaarbE4+zUEbe rVM7SHnUtzpoVMDnvp8z8s8EA0SmMpWNAH+yd1lYLNt4yknVmru3s9uWaXeXVw8m/fUeezd9r9i RYw== X-Received: from pgbo38.prod.google.com ([2002:a63:5a26:0:b0:cc1:e48a:53dd]) (user=wakel job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:4311:b0:3c3:bbe6:95de with SMTP id adf61e73a8af0-3da39eacfc8mr52193525637.6.1789012104294; Wed, 09 Sep 2026 20:48:24 -0700 (PDT) Date: Thu, 10 Sep 2026 03:48:21 +0000 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.1003.g10538fe699-goog Message-ID: <20260910034821.2935214-1-wakel@google.com> Subject: [PATCH] selftests: rtc: Support harness test filtering and arguments From: Wake Liu To: Alexandre Belloni , Shuah Khan Cc: linux-rtc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Wake Liu Content-Type: text/plain; charset="UTF-8" rtctest implements its own main() function with a rigid switch (argc) check that only accepts an optional single argument for the RTC device node path. This prevents kselftest_harness standard arguments from working properly: 1. Passing filter options like -t or -T triggers a usage error because argc is greater than 2. 2. Passing -l or -h causes rtctest to treat "-l" or "-h" as the device node path and fail with access() errors before ever reaching the harness argument checker. Parse command line arguments with getopt() to pass all kselftest harness options (such as -t, -T, -v, -V, -f, -F, -r, -d, -h, and -l) through to test_harness_run(), while preserving the ability to specify an optional RTC device node path as a non-option argument. Also ensure optind is reset before invoking test_harness_run() so the harness can inspect the options, and bypass device accessibility checks when help or test listing is requested. Signed-off-by: Wake Liu --- tools/testing/selftests/rtc/rtctest.c | 44 +++++++++++++++++++++------ 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/rtc/rtctest.c b/tools/testing/selftests/rtc/rtctest.c index 8047d9879039..57dda87ba813 100644 --- a/tools/testing/selftests/rtc/rtctest.c +++ b/tools/testing/selftests/rtc/rtctest.c @@ -486,18 +486,44 @@ TEST_F_TIMEOUT(rtc, alarm_wkalm_set_minute, 65) { int main(int argc, char **argv) { int ret = -1; + int opt, i; + int non_opt = 0; + + while ((opt = getopt(argc, argv, "dhlF:f:V:v:t:T:r:")) != -1) { + switch (opt) { + case 'h': + fprintf(stderr, + "Usage: %s [-h|-l|-d] [-t|-T|-v|-V|-f|-F|-r name] [rtcdev]\n\n", + argv[0]); + optind = 1; + return test_harness_run(argc, argv); + case 'l': + optind = 1; + return test_harness_run(argc, argv); + case '?': + fprintf(stderr, + "Usage: %s [-h|-l|-d] [-t|-T|-v|-V|-f|-F|-r name] [rtcdev]\n", + argv[0]); + return KSFT_FAIL; + default: + break; + } + } - switch (argc) { - case 2: - rtc_file = argv[1]; - /* FALLTHROUGH */ - case 1: - break; - default: - fprintf(stderr, "usage: %s [rtcdev]\n", argv[0]); - return 1; + for (i = optind; i < argc; i++) { + if (non_opt == 0) { + rtc_file = argv[i]; + non_opt++; + } else { + fprintf(stderr, + "Usage: %s [-h|-l|-d] [-t|-T|-v|-V|-f|-F|-r name] [rtcdev]\n", + argv[0]); + return KSFT_FAIL; + } } + optind = 1; + /* Run the test if rtc_file is accessible */ if (access(rtc_file, R_OK) == 0) ret = test_harness_run(argc, argv); -- 2.55.0.979.g7e5102b832-goog