Re: [PATCH] rtc: bd70528: properly enable wakeup

[Andreas Kemnade <andreas@kemnade.info>]

On Thu, 10 Sep 2026 13:28:23 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> On 10/09/2026 12:25, Andreas Kemnade wrote:
> > Wakeup on RTC alarm now only accidentially works when wakeup for the power
> > button connected to the same PMIC is also enabled. Fix that by properly
> > specifying the wakeup irq.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>  
> 
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> 
> Thanks!
> 
> By the way, I am not 100% sure all of the PMICs using this driver even 
> have a power button input. I suspect some doesn't (maybe bd71815). I 
> wouldn't be against Fixes -tag :)
> 
looking at mfd driver:

                 * BD71815 data-sheet does not list the power-button IRQ so we
                 * don't use it.
                 */
                button_irq = 0;
....

 if (button_irq) {
                ret = rohm_register_pwrbutton(&i2c->dev, button_irq,
                                              "bd71828-pwrkey", true, irq_domain);
                if (ret)
                        return ret;
        }
....
so you are right about the power button.
Sashiko wants some error-checking there, so I'll send a
v2 with a fixes-tag and error checking.

Regards,
Andreas