Linux RTC
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-kernel@vger.kernel.org,
	 Matti Vaittinen <mazziesaccount@gmail.com>,
	 Andreas Kemnade <andreas@kemnade.info>,
	linux-rtc@vger.kernel.org
Subject: [PATCH v2] rtc: bd70528: properly enable wakeup
Date: Wed, 16 Sep 2026 23:24:15 +0200	[thread overview]
Message-ID: <20260916-rtc-bd-v2-1-ee5c15937d25@kemnade.info> (raw)

Wakeup on RTC alarm now only accidentially works when wakeup for the power
button connected to the same PMIC is also enabled. Fix that by properly
specifying the wakeup irq.

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Changes in v2:
- add error check
- Link to v1: https://patch.msgid.link/20260910092558.1008998-1-andreas@kemnade.info

To: Matti Vaittinen <mazziesaccount@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/rtc/rtc-bd70528.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/rtc/rtc-bd70528.c b/drivers/rtc/rtc-bd70528.c
index 482810b61495d..a58cf85bc1beb 100644
--- a/drivers/rtc/rtc-bd70528.c
+++ b/drivers/rtc/rtc-bd70528.c
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
+#include <linux/pm_wakeirq.h>
 #include <linux/regmap.h>
 #include <linux/rtc.h>
 
@@ -321,6 +322,10 @@ static int bd70528_probe(struct platform_device *pdev)
 	device_set_wakeup_capable(&pdev->dev, true);
 	device_wakeup_enable(&pdev->dev);
 
+	ret = devm_pm_set_wake_irq(&pdev->dev, irq);
+	if (ret)
+		return ret;
+
 	rtc = devm_rtc_allocate_device(&pdev->dev);
 	if (IS_ERR(rtc)) {
 		dev_err(&pdev->dev, "RTC device creation failed\n");

---
base-commit: df2908090cda368b01ff43709f51890076c56157
change-id: 20260916-rtc-bd-7d7b0e1c31b0

Best regards,
--  
Andreas Kemnade <andreas@kemnade.info>


             reply	other threads:[~2026-09-16 21:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-16 21:24 Andreas Kemnade [this message]
2026-09-16 21:32 ` [PATCH v2] rtc: bd70528: properly enable wakeup sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260916-rtc-bd-v2-1-ee5c15937d25@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox