From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71A23C09EE; Wed, 16 Sep 2026 07:02:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789542164; cv=none; b=nKqsehWPEHPPNVpl+y97wwX/pLh5T4jZNNuoR+KvKXlEJ3e9djB/uIdHl5nNuvAw8Isa4f2GY5wi1VOOM4gVO5yxfFDrIvlp0mVreosQI+gyKceg7DxFmdqP8NKXxhTWSNM1mO5LzJFIpMsbJ4B+rE8dSG3RFgL0kN8nRwHM5dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789542164; c=relaxed/simple; bh=qnYTvIzQRutlNi3HyTuELIHlBxhokM61YWXps5Qh+CM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pjbB8GS0b7T0yVPWnm2NOIwiKIAYwZjszX+1LCQt+MyY+/Nj0XWHPI/6fTc/qXn1FItl2uX5S6q8ulB7lEyYYCXdqp+Xb4d2zM2U9sTzNadgSbbpG0tsKhBIUjLwOzn9FhhNYyk2j9XqT7TQHJmKCIBJDU+4vVpm7Al3Lw3eHOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-03 (Coremail) with SMTP id rQCowABnbDoKP6pqPeHeBw--.40270S2; Wed, 16 Sep 2026 15:02:34 +0800 (CST) From: Wentao Liang To: alexandre.belloni@bootlin.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, schung@nuvoton.com, ychuang3@nuvoton.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH 02/20] rtc: ma35d1: Fix clock leak in ma35d1_rtc_probe() Date: Wed, 16 Sep 2026 07:02:06 +0000 Message-Id: <20260916070206.1965294-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:rQCowABnbDoKP6pqPeHeBw--.40270S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uF13tF4fZw15Zr13tr17Awb_yoW8GF1fpF s3JFyYyryayrWrKayDGw18AF1qyayxKa48K3yvk39ag3W3ZF1UJrZ3tF109FykJrWkXr4Y qw18JF1rGa1UuaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkC14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Cr0_Gr1UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUFOzVUU UUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCRIMA2qqBo79QAAAsh In ma35d1_rtc_probe(), the clock is acquired using of_clk_get() and enabled with clk_prepare_enable(). However, if subsequent operations fail, or when the driver is unloaded, the clock is never disabled or put, resulting in reference count and resource leaks. Switch to devm_clk_get_enabled() to automatically handle enabling and resource cleanup on probe failure or driver removal. Fixes: dc0684adf3b6 ("rtc: Add driver for Nuvoton ma35d1 rtc controller") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/rtc/rtc-ma35d1.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-ma35d1.c b/drivers/rtc/rtc-ma35d1.c index cfcfc28060f6..43358d68565a 100644 --- a/drivers/rtc/rtc-ma35d1.c +++ b/drivers/rtc/rtc-ma35d1.c @@ -221,14 +221,10 @@ static int ma35d1_rtc_probe(struct platform_device *pdev) if (IS_ERR(rtc->rtc_reg)) return PTR_ERR(rtc->rtc_reg); - clk = of_clk_get(pdev->dev.of_node, 0); + clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(clk)) return dev_err_probe(&pdev->dev, PTR_ERR(clk), "failed to find rtc clock\n"); - ret = clk_prepare_enable(clk); - if (ret) - return ret; - if (!(rtc_reg_read(rtc, MA35_REG_RTC_INIT) & RTC_INIT_ACTIVE)) { ret = ma35d1_rtc_init(rtc, RTC_INIT_TIMEOUT); if (ret) -- 2.34.1