From: sashiko-bot@kernel.org
To: "Pablo Mazzini" <pmazzini@gmail.com>
Cc: linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev,
robh@kernel.org, conor+dt@kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 05/11] dt-bindings: rtc: sun6i-a31: add Allwinner B288
Date: Wed, 23 Sep 2026 20:28:54 +0000 [thread overview]
Message-ID: <20260923202854.7CF911F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260923201701.43391-5-pmazzini@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing clock-output-names schema constraint for b288
--
commit d061a16a5e55b66a00315843c7f4655412cd0e5f
Author: Pablo Mazzini <pmazzini@gmail.com>
dt-bindings: rtc: sun6i-a31: add Allwinner B288
The B288 RTC wires one alarm interrupt, not two.
> diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> index f2b91186ed377..1699e3576b915 100644
> --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> @@ -19,6 +19,7 @@ properties:
> - enum:
> - allwinner,sun6i-a31-rtc
> - allwinner,sun8i-a23-rtc
> + - allwinner,sun8i-b288-rtc
> - allwinner,sun8i-h3-rtc
> - allwinner,sun8i-r40-rtc
> - allwinner,sun8i-v3-rtc
[ ... ]
> @@ -162,6 +163,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - allwinner,sun8i-b288-rtc
> - allwinner,sun8i-r40-rtc
> - allwinner,sun50i-h616-rtc
> - allwinner,sun50i-r329-rtc
[Severity: Low]
Does this new b288 compatible string also need to be added to one of the
clock-output-names conditional blocks?
It is added here for the interrupts constraint, but omitted from the if
blocks managing clock-output-names. Without an explicit block for the b288,
invalid device trees specifying the wrong number of clocks might silently
pass validation due to the generic top-level fallback limits.
For example, other variants in this file are explicitly constrained:
allOf:
- if:
properties:
compatible:
contains:
enum:
- allwinner,sun8i-a23-rtc
- allwinner,sun8i-r40-rtc
- allwinner,sun8i-v3-rtc
then:
properties:
clock-output-names:
minItems: 2
maxItems: 2
Should a similar constraint (or false) be applied for the b288 variant?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923201701.43391-1-pmazzini@gmail.com?part=5
next prev parent reply other threads:[~2026-09-23 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260923201701.43391-1-pmazzini@gmail.com>
2026-09-23 20:16 ` [PATCH v1 05/11] dt-bindings: rtc: sun6i-a31: add Allwinner B288 Pablo Mazzini
2026-09-23 20:28 ` sashiko-bot [this message]
2026-09-23 20:16 ` [PATCH v1 06/11] rtc: sun6i: add Allwinner B288 compatible Pablo Mazzini
2026-09-23 20:30 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923202854.7CF911F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=pmazzini@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox