Re: [PATCH] rtc: omap: fail rtc-only suspend without a power-off RTC

[sashiko-bot@kernel.org]

> omap_rtc_power_off_program() dereferences omap_rtc_power_off_rtc
> unconditionally, but that pointer is only set when an RTC with the
> "system-power-controller" property probed while pm_power_off was still
> free, and it is cleared again when that RTC is removed.
> 
> pm33xx uses the function for rtc-only suspend whenever off mode is
> enabled and an "rtc0" class device exists, which guarantees none of
> that. Without the property, with another driver owning pm_power_off,
> or with a different RTC registered as rtc0, suspending to mem
> dereferences NULL in the cpu_suspend() finisher.
> 
> Return -ENODEV when no power-off RTC is set up, and propagate it from
> am33xx_rtc_only_idle(). A non-zero return from the finisher makes
> cpu_suspend() abort, so pm33xx reports a suspend failure instead of
> oopsing.
> 
> Fixes: 5a99ae0092fe ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004215843.396867-1-rosenp@gmail.com?part=1