From: Imre Kaloz <kaloz@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Joshua Kinard <linux@kumba.dev>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] rtc: ds1685: power-off fixes
Date: Tue, 13 Oct 2026 14:02:05 +0200 [thread overview]
Message-ID: <20261013120208.11268-1-kaloz@kernel.org> (raw)
Three fixes for ds1685_rtc_poweroff(), on SGI O2 and Octane machines.
Patch 1 arms the wake-up alarm only if an alarm is set, so that stale
alarm registers no longer power the machine back on.
Patch 2 replaces the sleep before the PAB write with a busy wait, as
power-off handlers must not sleep.
Patch 3 repeats the PAB write, clearing the kickstart and wake-up
flags with it, until power is removed.
Patch 1 was tested on an O2, and the whole series on an Octane.
Changes in v2:
- New patch 2: use mdelay() instead of msleep() before the PAB write.
- Patch 3 (v1 patch 2): use mdelay() instead of msleep() in the
repeat loop.
v1: https://lore.kernel.org/all/20261013094930.574-1-kaloz@kernel.org/
Imre Kaloz (3):
rtc: ds1685: arm the wake-up alarm at power-off only if an alarm is
set
rtc: ds1685: do not sleep in the power-off handler
rtc: ds1685: keep setting PAB until power is removed
drivers/rtc/rtc-ds1685.c | 40 ++++++++++++++++++++++++++--------------
1 file changed, 26 insertions(+), 14 deletions(-)
base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907
--
2.47.3
next reply other threads:[~2026-10-13 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 12:02 Imre Kaloz [this message]
2026-10-13 12:02 ` [PATCH v2 1/3] rtc: ds1685: arm the wake-up alarm at power-off only if an alarm is set Imre Kaloz
2026-10-13 12:15 ` sashiko-bot
2026-10-13 12:02 ` [PATCH v2 2/3] rtc: ds1685: do not sleep in the power-off handler Imre Kaloz
2026-10-13 12:24 ` sashiko-bot
2026-10-13 12:02 ` [PATCH v2 3/3] rtc: ds1685: keep setting PAB until power is removed Imre Kaloz
2026-10-13 12:30 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013120208.11268-1-kaloz@kernel.org \
--to=kaloz@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@kumba.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox