Linux RTC
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Stefan Kerkmann <s.kerkmann@pengutronix.de>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
	bruno.thomsen@gmail.com, giampiero@sferalabs.cc,
	p.rosenberger@kunbus.com, antonio@amsobr.com,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH 3/4] rtc: add battery low voltage detection feature
Date: Sat, 21 Nov 2026 13:36:32 +0100	[thread overview]
Message-ID: <20261121123632576d91fd@mail.local> (raw)
In-Reply-To: <20261120184027.650463c9b2a1ee1d5528ef36@hugovil.com>

On 20/11/2026 18:40:27-0500, Hugo Villeneuve wrote:
> Hi Alexandre,
> 
> On Fri, 20 Nov 2026 17:12:49 +0100
> Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
> 
> > On 20/11/2026 14:40:50+0100, Alexandre Belloni wrote:
> > > Hello,
> > > 
> > > On 06/08/2026 14:55:00+0200, Stefan Kerkmann wrote:
> > > > 
> > > > 
> > > > On 3/11/26 21:02, Hugo Villeneuve wrote:
> > > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > > > > 
> > > > > Some RTCs have a battery low voltage detection function. Add new feature
> > > > > so that it can be enabled, disabled or queried at runtime.
> > > > > 
> > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > > > > ---
> > > > >   include/uapi/linux/rtc.h | 7 ++++++-
> > > > >   1 file changed, 6 insertions(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/include/uapi/linux/rtc.h b/include/uapi/linux/rtc.h
> > > > > index 97aca4503a6a3..596eec119bb3a 100644
> > > > > --- a/include/uapi/linux/rtc.h
> > > > > +++ b/include/uapi/linux/rtc.h
> > > > > @@ -134,18 +134,23 @@ struct rtc_param {
> > > > >   #define RTC_FEATURE_CORRECTION		5
> > > > >   #define RTC_FEATURE_BACKUP_SWITCH_MODE	6
> > > > >   #define RTC_FEATURE_ALARM_WAKEUP_ONLY	7
> > > > > -#define RTC_FEATURE_CNT			8
> > > > > +#define RTC_FEATURE_BATTERY_LOW_DETECT	8
> > > > > +#define RTC_FEATURE_CNT			9
> > > 
> > > This is adding a new ABI and it took me a while to find enough time to
> > > review the datasheet for the RTCs  we support and others. What we need
> > > instead of a boolean is a voltage threshold. So maybe this should be
> > > better named something like RTC_FEATURE_BATTERY_LOW_THRES_MV
> 
> I am not sure to understand that proposal, because with the
> pcf2127/31, you can enable the low battery detection function, but you
> cannot select the threshold voltage...

This is exactly my point, there are RTCs where you can select the
threshold voltage so we have to design for them. We can have 0mv mean
disabled because we are never going to have a 0 or negative threshold.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2026-11-21 12:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 20:02 [PATCH 0/4] rtc: pcf2127: add support for battery low voltage detection Hugo Villeneuve
2026-03-11 20:02 ` [PATCH 1/4] rtc: pcf2127: remove redundant break statement in switch-case Hugo Villeneuve
2026-03-11 20:02 ` [PATCH 2/4] rtc: pcf2127: add pcf2127_pwrmng_get/set Hugo Villeneuve
2026-08-06 12:53   ` Stefan Kerkmann
2026-03-11 20:02 ` [PATCH 3/4] rtc: add battery low voltage detection feature Hugo Villeneuve
2026-08-06 12:55   ` Stefan Kerkmann
2026-11-20 13:40     ` Alexandre Belloni
2026-11-20 16:12       ` Alexandre Belloni
2026-11-20 23:40         ` Hugo Villeneuve
2026-11-21 12:36           ` Alexandre Belloni [this message]
2026-03-11 20:02 ` [PATCH 4/4] rtc: pcf2127: support battery low voltage detection function Hugo Villeneuve
2026-08-06 12:55   ` Stefan Kerkmann
2026-07-29 15:18 ` [PATCH 0/4] rtc: pcf2127: add support for battery low voltage detection Stefan Kerkmann
2026-08-25 12:59   ` Hugo Villeneuve
2026-08-25  7:31 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121123632576d91fd@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=antonio@amsobr.com \
    --cc=bruno.thomsen@gmail.com \
    --cc=giampiero@sferalabs.cc \
    --cc=hugo@hugovil.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=p.rosenberger@kunbus.com \
    --cc=s.kerkmann@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox