linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <Sergiu.Moga@microchip.com>, <a.zummo@towertech.it>,
	<alexandre.belloni@bootlin.com>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski@canonical.com>,
	<Nicolas.Ferre@microchip.com>, <Claudiu.Beznea@microchip.com>
Cc: <linux-rtc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs
Date: Fri, 4 Mar 2022 11:13:35 +0000	[thread overview]
Message-ID: <301e9ccc-a356-aa4c-a1c6-896beafe9472@microchip.com> (raw)
In-Reply-To: <20220303140626.38129-4-sergiu.moga@microchip.com>

On 3/3/22 16:06, Sergiu Moga wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> As the DT specification recommends, the node names should be of a
> generic nature. Thus, the most appropriate generic node name for
> the at91 rtt IPs is the "rtc" node name.
> 
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  arch/arm/boot/dts/sam9x60.dtsi | 2 +-
>  arch/arm/boot/dts/sama7g5.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sam9x60.dtsi b/arch/arm/boot/dts/sam9x60.dtsi
> index 57ba47c54043..af7602cb65f7 100644
> --- a/arch/arm/boot/dts/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/sam9x60.dtsi
> @@ -688,7 +688,7 @@ shutdown_controller: shdwc@fffffe10 {
>                                 status = "disabled";
>                         };
> 
> -                       rtt: rtt@fffffe20 {
> +                       rtt: rtc@fffffe20 {
>                                 compatible = "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
>                                 reg = <0xfffffe20 0x20>;
>                                 interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index 1530d88ce80f..87af6c680322 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -133,7 +133,7 @@ shdwc: shdwc@e001d010 {
>                         status = "disabled";
>                 };
> 
> -               rtt: rtt@e001d020 {
> +               rtt: rtc@e001d020 {
>                         compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
>                         reg = <0xe001d020 0x30>;
>                         interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.25.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


  parent reply	other threads:[~2022-03-04 11:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 14:06 [PATCH v2 0/5] dt-bindings: rtc: convert at91sam9 bindings to Sergiu Moga
2022-03-03 14:06 ` [PATCH v2 1/5] ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi" file Sergiu Moga
2022-03-03 16:07   ` Alexandre Belloni
2022-03-04 13:10     ` Sergiu.Moga
2022-03-03 14:06 ` [PATCH v2 2/5] ARM: dts: at91: Add the required `atmel,rtt-rtc-time-reg` property Sergiu Moga
2022-03-04 11:06   ` [PATCH v2 2/5] ARM: dts: at91: Add the required `atmel, rtt-rtc-time-reg` property Tudor.Ambarus
2022-03-03 14:06 ` [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs Sergiu Moga
2022-03-03 14:47   ` Krzysztof Kozlowski
2022-03-04 11:13   ` Tudor.Ambarus [this message]
2022-03-03 14:06 ` [PATCH v2 4/5] dt-bindings: rtc: convert at91sam9 bindings to json-schema Sergiu Moga
2022-03-03 14:21   ` Krzysztof Kozlowski
2022-03-04 13:17     ` Sergiu.Moga
2022-03-03 14:06 ` [PATCH v2 5/5] dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list Sergiu Moga
2022-03-03 14:48   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=301e9ccc-a356-aa4c-a1c6-896beafe9472@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=Sergiu.Moga@microchip.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).