From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 30 Jul 2015 09:16:12 -0700 (PDT) From: suneelgarapati@gmail.com To: rtc-linux Cc: suneel.garapati@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, a.zummo@towertech.it, michals@xilinx.com, sorenb@xilinx.com, mark.rutland@arm.com Message-Id: <3278813f-e7ac-4749-a040-25ba0508ab29@googlegroups.com> In-Reply-To: <20150723115555.GC12330@leverpostej> References: <1437648710-6857-1-git-send-email-suneel.garapati@xilinx.com> <20150723115555.GC12330@leverpostej> Subject: [rtc-linux] Re: [PATCH 1/2] devicetree: bindings: rtc: add bindings for xilinx zynqmp rtc MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_7448_287527463.1438272973091" Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , ------=_Part_7448_287527463.1438272973091 Content-Type: multipart/alternative; boundary="----=_Part_7449_1352081459.1438272973092" ------=_Part_7449_1352081459.1438272973092 Content-Type: text/plain; charset=UTF-8 Hi Mark, On Thursday, July 23, 2015 at 5:26:22 PM UTC+5:30, Mark Rutland wrote: > > On Thu, Jul 23, 2015 at 11:51:49AM +0100, Suneel Garapati wrote: > > adds file for description on device node bindings for RTC > > found on Xilinx Zynq Ultrascale+ MPSoC. > > > > Signed-off-by: Suneel Garapati > > > --- > > Documentation/devicetree/bindings/rtc/xlnx-rtc.txt | 25 > ++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/rtc/xlnx-rtc.txt > > > > diff --git a/Documentation/devicetree/bindings/rtc/xlnx-rtc.txt > b/Documentation/devicetree/bindings/rtc/xlnx-rtc.txt > > new file mode 100644 > > index 0000000..2b05243 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/xlnx-rtc.txt > > @@ -0,0 +1,25 @@ > > +* Xilinx Zynq Ultrascale+ MPSoC Real Time Clock > > + > > +RTC controller for the Xilinx Zynq MPSoC Real Time Clock > > +Separate IRQ lines for seconds and alarm > > + > > +Required properties: > > +- compatible: Should be "xlnx,zynqmp-rtc" > > +- reg: Physical base address of the controller and length > > + of memory mapped region. > > +- interrupts: IRQ lines for the RTC. > > +- interrupt names: Names for interrupt lines > > interrupt-names has a '-', and you need to state which names are > expected. > > I will add the names and resend > > + > > +Optional: > > +- calibration: calibration value for 1 sec period which will > > + be programmed directly to calibration register > > When and why would I set this? Crystal efficiency varies from board to board based on ppm, this effects the # ticks per sec and also temperature changes has an effect. This is one way to configure calibration value of # ticks per sec through device tree, based on observations for a board. Regards, Suneel > > Mark. > > > + > > +Example: > > +rtc: rtc@ffa60000 { > > + compatible = "xlnx,zynqmp-rtc"; > > + reg = <0x0 0xffa60000 0x100>; > > + interrupt-parent = <&gic>; > > + interrupts = <0 26 4>, <0 27 4>; > > + interrupt-names = "alm", "sec"; > > + calibration = <0x198233>; > > +}; > > -- > > 2.1.2 > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-ar...@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ------=_Part_7449_1352081459.1438272973092 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Mark,

On Thursday, July 23, 2015 at 5:26:22 PM UTC+5:30, Mark Rut= land wrote:
On Thu, Jul 23, 201= 5 at 11:51:49AM +0100, Suneel Garapati wrote:
> adds file for description on device node bindings for RTC
> found on Xilinx Zynq Ultrascale+ MPSoC.
>=20
> Signed-off-by: Suneel Garapati <suneel....@xilinx.com>
> ---
> =C2=A0Documentation/devicetree/bindings/rtc/xlnx-rtc.txt | 25 ++++= ++++++++++++++++++
> =C2=A01 file changed, 25 insertions(+)
> =C2=A0create mode 100644 Documentation/devicetree/bindings/rtc/xln= x-rtc.txt
>=20
> diff --git a/Documentation/devicetree/bindings/rtc/xlnx-rtc.txt b/= Documentation/devicetree/bindings/rtc/xlnx-rtc.txt
> new file mode 100644
> index 0000000..2b05243
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/xlnx-rtc.txt
> @@ -0,0 +1,25 @@
> +* Xilinx Zynq Ultrascale+ MPSoC Real Time Clock
> +
> +RTC controller for the Xilinx Zynq MPSoC Real Time Clock
> +Separate IRQ lines for seconds and alarm
> +
> +Required properties:
> +- compatible: Should be "xlnx,zynqmp-rtc"
> +- reg: Physical base address of the controller and length
> + =C2=A0 =C2=A0 =C2=A0 of memory mapped region.
> +- interrupts: IRQ lines for the RTC.
> +- interrupt names: Names for interrupt lines

interrupt-names has a '-', and you need to state which names ar= e
expected.

I will add the names and resend=C2=A0
> +
> +Optional:
> +- calibration: calibration value for 1 sec period which will
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0be programmed directly to calibration regi= ster

When and why would I set this?
Crystal efficiency vari= es from board to board based on ppm, this effects the # ticks per sec and a= lso temperature changes has an effect.
This is one way to configu= re calibration value of # ticks per sec through device tree, based on obser= vations for a board.

Regards,
Suneel=C2= =A0



Mark.

> +
> +Example:
> +rtc: rtc@ffa60000 {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0compatible =3D &q= uot;xlnx,zynqmp-rtc";
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0reg =3D <0x0 0= xffa60000 0x100>;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0interrupt-parent = =3D <&gic>;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0interrupts =3D &l= t;0 26 4>, <0 27 4>;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0interrupt-names = =3D "alm", "sec";
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0calibration =3D &= lt;0x198233>;
> +};
> --
> 2.1.2
>=20
> _______________________________________________
> linux-arm-kernel mailing list
> linux-ar...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-a= rm-kernel
>=20

--
--
You received this message because you are subscribed to "rtc-linux&quo= t;.
Membership options at = http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups &= quot;rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux= +unsubscribe@googlegroups.com.
For more options, visit http= s://groups.google.com/d/optout.
------=_Part_7449_1352081459.1438272973092-- ------=_Part_7448_287527463.1438272973091--