From: shuah <shuah@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Kees Cook <keescook@chromium.org>,
Jeffrin Thalakkottoor <jeffrin@rajagiritech.edu.in>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, shuah <shuah@kernel.org>
Subject: Re: [PATCH 0/2] kselftest: fix rtctest timeout
Date: Thu, 23 May 2019 17:32:35 -0600 [thread overview]
Message-ID: <3846d273-7b8e-8bb8-a3d4-04fd382d8324@kernel.org> (raw)
In-Reply-To: <9c94c2b7-153d-ef75-c474-9bae49d6a039@kernel.org>
On 5/23/19 4:57 PM, shuah wrote:
> On 5/23/19 4:42 PM, Alexandre Belloni wrote:
>> Hi,
>>
>> Commit a745f7af3cbd ("selftests/harness: Add 30 second timeout per
>> test") wrongly assumed that no individual test would run for more than
>> 30 seconds and this silently broke rtctest.
>>
>> Please consider the following patches as fixes for v5.2 to avoid having
>> any non working release.
>>
>> Thanks,
>>
>> Alexandre Belloni (2):
>> selftests/harness: Allow test to configure timeout
>> selftests: rtc: rtctest: specify timeouts
>>
>> tools/testing/selftests/kselftest_harness.h | 17 ++++++++++++-----
>> tools/testing/selftests/rtc/rtctest.c | 6 +++---
>> 2 files changed, 15 insertions(+), 8 deletions(-)
>>
>
> Thanks for fixing them quickly.
>
> I will pull these in. I have one more fix from Kees already queued
> up.
>
> Jeffrin! Would you like to test these to see if they work for you
> and send Tested-by tag.
>
> I don't see 1/2 in my Inbox. I have Kees's reply to it. Odd.
>
It showed up late. I have 1/2 in my Inbox now. Must have taken a scenic
route. :)
thanks,
-- Shuah
prev parent reply other threads:[~2019-05-23 23:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 22:42 [PATCH 0/2] kselftest: fix rtctest timeout Alexandre Belloni
2019-05-23 22:42 ` [PATCH 1/2] selftests/harness: Allow test to configure timeout Alexandre Belloni
2019-05-23 22:49 ` Kees Cook
2019-05-23 22:42 ` [PATCH 2/2] selftests: rtc: rtctest: specify timeouts Alexandre Belloni
2019-05-23 22:50 ` Kees Cook
2019-05-23 22:57 ` [PATCH 0/2] kselftest: fix rtctest timeout shuah
2019-05-23 23:32 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3846d273-7b8e-8bb8-a3d4-04fd382d8324@kernel.org \
--to=shuah@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=jeffrin@rajagiritech.edu.in \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).